Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest releases #159
Update to latest releases #159
Changes from 1 commit
bfe7f26
d545a03
80ff357
4dd1e85
b574679
79a9b22
688e97c
a44b111
b713621
056db96
2e2b01f
27aa509
f7e45c2
f84cb07
6112831
72cb4e3
d5cf2e1
16aa086
dde5736
967e738
7ef4811
92f5465
bcdbbd3
5ddf8be
d79b177
f524e29
923a4ac
c2daaf9
74f2681
698bce3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as below - just use the
MaxAsync
callThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, this query can be rewritten in a much less expensive way:
Akka.Persistence.MongoDB/src/Akka.Persistence.MongoDb/Journal/MongoDbJournal.cs
Lines 82 to 85 in 38a0c49
We have a sorted index built on top of the
Ordering
column. Just select the maximum value from it. Don't do an entire table scan. That turns this into a O(1) query rather than an O(n) query.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than do this, why now just use
CountAsync
on the MongoDb driver itself?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have now deleted that...I only created it while I was trying to understand the issue with
ReplayAllEventsAsyn