Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Akka.Persistence.Query CurrentEventsByTag locks up after 500 events #80

Closed
Aaronontheweb opened this issue Oct 3, 2019 · 2 comments
Closed

Akka.Persistence.Query CurrentEventsByTag locks up after 500 events #80

Aaronontheweb opened this issue Oct 3, 2019 · 2 comments
Labels
bug
Milestone
v1.3.14

Comments

@Aaronontheweb
Copy link
Member

Ran into this while replaying a large data set last week - going to work on a reproducer + fix for it.
@Aaronontheweb Aaronontheweb added this to the v1.3.14 milestone Oct 3, 2019
Aaronontheweb added a commit to Aaronontheweb/Akka.Persistence.MongoDB that referenced this issue Oct 3, 2019
@Aaronontheweb
added reproduction spec for akkadotnet#80
173b2d8
@Aaronontheweb Aaronontheweb mentioned this issue Oct 3, 2019
Merged
@Aaronontheweb
Copy link
Member Author

So the bug, best as I can summarize it:

  1. The RecoverySuccess message sent back to the CurrentEventsByTagPublisher contains the wrong sequence number. Right now we are sending back the highest sequence number found in the first limit messages, where limit defaults to 500. This is wrong - we should query to see _what the highest sequence number is for this query at the time it began.
  2. So we need to change the MongoDbJournal itself to support this, and it's possible that the underlying EventsByTagPublisher implementations have bugs in their guts too.

Going to begin working on this...

@Aaronontheweb
Copy link
Member Author

Also, it's possible that CurrentEventsByPersistentId might have this issue too.

Aaronontheweb added a commit to Aaronontheweb/Akka.Persistence.MongoDB that referenced this issue Oct 4, 2019
@Aaronontheweb
close akkadotnet#80 - fixed EventsByTag pagination
c6261af
@Aaronontheweb Aaronontheweb mentioned this issue Oct 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v1.3.14
Development

No branches or pull requests
1 participant
@Aaronontheweb