Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message when coordinator not found #28576

Merged
merged 1 commit into from
Feb 7, 2020

Conversation

chbatey
Copy link
Contributor

@chbatey chbatey commented Feb 7, 2020

Led users to think that the node had left the cluster when not starting
sharding on every node with the correct roles.

Led users to think that the node had left the cluster when not starting
sharding on every node with the correct roles.
@akka-ci akka-ci added validating PR is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed validating PR is currently being validated by Jenkins labels Feb 7, 2020
@akka-ci
Copy link

akka-ci commented Feb 7, 2020

Test PASSed.

Copy link
Contributor

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@octonato octonato merged commit 1b4da3d into akka:master Feb 7, 2020
@chbatey chbatey deleted the shard-no-coordinator-error-message branch February 10, 2020 09:23
zbynek001 added a commit to zbynek001/akka.net that referenced this pull request Mar 24, 2020
zbynek001 added a commit to zbynek001/akka.net that referenced this pull request Mar 26, 2020
Aaronontheweb added a commit to akkadotnet/akka.net that referenced this pull request Mar 27, 2020
* Avoid dead letter for rebalance timeout msg

migrated from akka/akka#28274

* Reconsider cluster.role.<role-name>.min-nr-of-members fallback
migrated from akka/akka#28203

* Use dedicated message for PersistentShardCoodinator termination instead of PoisonPill
migrated from akka/akka#28104

* Don't initialize durable keys when rememberEntities not used
migrated from akka/akka#28568

* Improve error message when coordinator not found
migrated from akka/akka#28576

* Shard region registration to more potential oldest

* Keep track of Leaving and Exiting members in ShardRegion and
  attempt to register to coordinator at several of the oldest if
  they have status Leaving and Exiting. Include all up to and
  including the first member with status Up.
* Sending to wrong node doesn't matter, will be suppressed deadLetter.
* Same for the GracefulShutdownReq which already had that intention by
  sending to 2 oldest.

migrated from akka/akka#28470

* Log non-completed rebalance at warning level
migrated from akka/akka#28335

* api approval fix

* review fixes

Co-authored-by: Aaron Stannard <aaron@petabridge.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tested PR that was successfully built and tested by Jenkins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants