fix: Progress bucket count query if empty #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* the bucket queries continues from the end of the previous * the limit of 10000 times 10 seconds is around 28 hours * meaning that if there were no new events for 28 hours the queries will not progress since it will not find any more * solution here is to append empty bucket at the end in that case
patriknw
commented
Jan 15, 2025
core/src/main/scala/akka/persistence/r2dbc/internal/BySliceQuery.scala
Outdated
Show resolved
Hide resolved
| @@ -74,4 +77,35 @@ trait TestDbLifecycle extends BeforeAndAfterAll { this: Suite => | |||
| super.beforeAll() | |||
| } | |||
|
|
|||
| // to be able to store events with specific timestamps | |||
| def writeEvent(slice: Int, persistenceId: String, seqNr: Long, timestamp: Instant, event: String): Unit = { | |||
There was a problem hiding this comment.
moved this here since it was used in several tests
1267a5a to
0fc7dfa
Compare
pvlugter
approved these changes
Jan 16, 2025
core/src/test/scala/akka/persistence/r2dbc/query/BucketCountSpec.scala
Outdated
Show resolved
Hide resolved
|
Also needs a mima filter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #641