Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default to 'standard' retry mode #82

Merged
merged 4 commits into from
Oct 4, 2024
Merged

default to 'standard' retry mode #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1a61ad7
default to 'standard' retry mode
leviramsey Oct 2, 2024
1644762
tabs vs. spaces
leviramsey Oct 2, 2024
d5cbe76
good to see that there's test coverage
leviramsey Oct 2, 2024
b552e93
retries
leviramsey Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion core/src/main/resources/reference.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,8 @@ akka.persistence.dynamodb {

# Set the retry mode. Can be `default`, `legacy`, `standard`, or `adaptive`.
# See the documentation for the AWS SDK for Java for details.
retry-mode = default
# As of AWS SDK 2.25.59, the default for DynamoDB is `legacy`, which is not recommended
retry-mode = standard

# Maximum number of times that a single request should be retried, assuming it fails for a retryable error.
# Can be `default` for the default number of retries for the `retry-mode`, or override with a specific number.
Expand Down
8 changes: 4 additions & 4 deletions core/src/test/scala/akka/persistence/dynamodb/util/ClientProviderSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@ class ClientProviderSpec extends AnyWordSpec with Matchers with OptionValues {
httpSettings.tcpKeepAlive shouldBe false

val retryPolicy = overrideConfiguration.retryPolicy.toScala.value
retryPolicy.retryMode shouldBe RetryMode.LEGACY
retryPolicy.numRetries shouldBe 3
retryPolicy.retryMode shouldBe RetryMode.STANDARD
retryPolicy.numRetries shouldBe 2

val compressionConfiguration = overrideConfiguration.compressionConfiguration.toScala.value
compressionConfiguration.requestCompressionEnabled shouldBe true
Expand All @@ -82,7 +82,7 @@ class ClientProviderSpec extends AnyWordSpec with Matchers with OptionValues {
}

retry-policy {
retry-mode = standard
retry-mode = legacy
num-retries = 5
}

Expand Down Expand Up @@ -121,7 +121,7 @@ class ClientProviderSpec extends AnyWordSpec with Matchers with OptionValues {
httpSettings.tcpKeepAlive shouldBe true

val retryPolicy = overrideConfiguration.retryPolicy.toScala.value
retryPolicy.retryMode shouldBe RetryMode.STANDARD
retryPolicy.retryMode shouldBe RetryMode.LEGACY
retryPolicy.numRetries shouldBe 5

val compressionConfiguration = overrideConfiguration.compressionConfiguration.toScala.value
Expand Down