-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for pluggable metric reporting #81
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have a built-in provider for the CloudWatch metrics publisher?
And would be useful to document this. |
Not sure... if we were to have support for full config (since it looks to have a fairly full-featured builder), then yes; otherwise (like if it's just the defaults), then I don't know how useful it would actually be. Will write up some docs tonight. |
NB: I realized that (Of course, I suppose the interface should be |
I almost think a CloudWatch provider (and even this interface, since it's not DynamoDB specific) should be part of a general AWS support extension. But for the time being, this is "enough". |
core/src/main/scala/akka/persistence/dynamodb/util/SDKClientMetricsProvider.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good
References #80
This doesn't do the Cinnamon bit (how that bit would work is a mystery to me), but at least this would allow users to plug in the official CloudWatch
MetricsPublisher
or manually setup Cinnamon metrics.Roughly used the Akka Circuit Breaker instrumentation as a guide.