feat: reject events on retryable errors #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ran some tests with short API call timeouts, and with the event writes succeeding even if it times out, we won't want to mark those as rejected. |
patriknw
reviewed
Aug 21, 2024
core/src/main/scala/akka/persistence/dynamodb/journal/DynamoDBJournal.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/akka/persistence/dynamodb/journal/DynamoDBJournal.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/akka/persistence/dynamodb/journal/DynamoDBJournal.scala
Outdated
Show resolved
Hide resolved
ad918de to
e702ddd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #18
Reject events on retryable errors, rather than journal failure. Currently only for write throttling errors. API call timeouts could also be added, but given that it will be a client-side timeout then it's possible that the event has been persisted.
Not sure there's a way to create tests for this with local DynamoDB. Unless we mock out the journal dao with possible failures. Have tested with actual DynamoDB and a sample application.