This repository has been archived by the owner on Jul 2, 2019. It is now read-only.
Drop gulp #9
Merged
Drop gulp #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamakiri01
commented
Feb 19, 2018
tslint.json
Outdated
| @@ -16,12 +16,17 @@ | |||
| "interface-name": false, | |||
| "jsdoc-format": true, | |||
| "label-position": true, | |||
| "label-undefined": true, | |||
There was a problem hiding this comment.
TSLint 4.0で廃止？ palantir/tslint#1507
コンパイラによりカバーされます
palantir/tslint#877
kamakiri01
commented
Feb 19, 2018
tslint.json
Outdated
| "no-debugger": true, | ||
| "no-duplicate-key": true, |
There was a problem hiding this comment.
TSLint 4.0で廃止
コンパイラによりカバーされます
palantir/tslint#885
kamakiri01
commented
Feb 19, 2018
tslint.json
Outdated
| @@ -48,7 +52,6 @@ | |||
| "no-trailing-whitespace": true, | |||
| "no-unused-expression": true, | |||
| "no-unused-variable": true, | |||
| "no-unreachable": true, | |||
There was a problem hiding this comment.
TSLint 4.0で廃止
コンパイラによりカバーされます
palantir/tslint#661
xnv
approved these changes
Feb 22, 2018
yu-ogi
reviewed
Feb 22, 2018
package.json
Outdated
| "prepublish": "gulp clean && gulp compile", | ||
| "clean": "gulp clean", | ||
| "prepublish": "npm run clean && npm run build", | ||
| "clean": "rimraf lib && rimraf spec/build", |
There was a problem hiding this comment.
ディレクトリ削除であることをわかりやすくするために rimraf ./lib && rimraf ./spec/build としてしまっても良さそうに思いました。
yu-ogi
approved these changes
Feb 22, 2018
a669f88 to
13d2dca
Compare
|
publish される成果物に変更はないので、 version はbump されません。 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
このpull requestが解決する内容
開発環境におけるgulp利用をやめます。
概要
破壊的な変更を含んでいるか?