Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix Incorrect sed Regular Expression Handling Update tools.sh #1962

Closed
wants to merge 1 commit into from
Closed

fix: Fix Incorrect sed Regular Expression Handling Update tools.sh #1962

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion script/tools.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ function get_gotoolchain() {
if [[ ${gotoolchain} == "" ]]; then
# determine go toolchain from go version in go.mod
if which go > /dev/null 2>&1 ; then
local_goversion=$(GOTOOLCHAIN=local go version | cut -d ' ' -f 3 | sed 's/go*//' | tr -d '\n')
local_goversion=$(GOTOOLCHAIN=local go version | cut -d ' ' -f 3 | sed 's/^go//' | tr -d '\n')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will fail i believe. here is output of go version command

go version go1.23.4 darwin/arm64

if [[ $($SEMVER compare "v$local_goversion" v"$goversion") -ge 0 ]]; then
goversion=$local_goversion
else
Expand Down
Loading