feat: Bid pricing based on USD scale #1385
Conversation
bd032d8 to
bb06714
Compare
| if [ $curl_exit_status != 0 ]; then | ||
| exit $curl_exit_status | ||
| fi | ||
| usd_per_akt=$(jq '."akash-network"."usd"' <<<"$API_RESPONSE") |
There was a problem hiding this comment.
Since this is just bidding do we want to fail here if the answer for this number is 0?
There was a problem hiding this comment.
Think we should have a better backup then that, what if the oracle drops completely?
There was a problem hiding this comment.
Up on line 65, if curl fails the script fails. No bid happens.
|
@boz since this is just a script should be put this in a separate repo? |
I think it's okay to add to |
4779275 to
df9cea8
Compare
provider/bidengine/pricing_test.go
Outdated
| }) | ||
|
|
||
| go func() { | ||
| t.Error(http.ListenAndServe(addr, nil)) |
There was a problem hiding this comment.
It is best to use port 0 and get an ephemeral port in tests.
We should also shut down the server before returning.
There was a problem hiding this comment.
Done. Added httptest server which random assigns a port.
f190d7f to
3b9a57d
Compare
This PR adds a script that uses the current USD price of an AKT to calculate the bid price.
Description
Motivation and Context
design/approvedlabelHow Has This Been Tested?
Types of changes
Checklist:
git commit -s