Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experiment with getting reformatted chunks from Black #221

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Experiment with getting reformatted chunks from Black #221

wants to merge 4 commits into from

Conversation

akaihola
Copy link
Owner

By getting results of reformatting from Black in chunks instead of complete files, we should be able to apply reformat modified sections with more granularity.

This is an experiment and to be considered carefully, since it involves re-implementing parts of Black, and will be sensitive to internal changes in Black versions.

@akaihola akaihola added the enhancement New feature or request label Oct 11, 2021
@akaihola akaihola self-assigned this Oct 11, 2021
@akaihola akaihola marked this pull request as draft October 11, 2021 06:45
@sourcery-ai sourcery-ai bot mentioned this pull request Oct 11, 2021
Closed
@akaihola akaihola changed the title Draft: Experiment with getting reformatted chunks from Black Experiment with getting reformatted chunks from Black Oct 11, 2021
@akaihola akaihola mentioned this pull request Oct 11, 2021
Open
@sourcery-ai sourcery-ai bot mentioned this pull request Oct 27, 2021
Merged
@akaihola akaihola force-pushed the chunks-from-black branch 3 times, most recently from b05e066 to 77de983 Compare October 31, 2021 12:28
@akaihola akaihola force-pushed the chunks-from-black branch 3 times, most recently from 3f7ce48 to 2bdfe00 Compare February 23, 2022 16:01
@akaihola akaihola added help wanted Extra attention is needed maybe invalid? Can't reproduce, or seems already fixed, or need more information labels Feb 23, 2022
@akaihola
Copy link
Owner Author

I think I ran into a dead end and started to doubt whether this can be done at all.

@akaihola akaihola force-pushed the chunks-from-black branch 3 times, most recently from 60f1eaf to 85d2b50 Compare February 27, 2022 14:39
@akaihola akaihola force-pushed the chunks-from-black branch 3 times, most recently from 9000497 to 55a8138 Compare March 14, 2022 17:52
@akaihola akaihola force-pushed the chunks-from-black branch 3 times, most recently from 89a9272 to 6204862 Compare March 26, 2022 21:42
@akaihola akaihola force-pushed the chunks-from-black branch 2 times, most recently from b0b2cd5 to b75d818 Compare March 30, 2022 17:35
@akaihola akaihola force-pushed the chunks-from-black branch 4 times, most recently from 9ed96ee to 4a524b0 Compare April 7, 2022 19:53
@akaihola akaihola force-pushed the chunks-from-black branch 3 times, most recently from f7765ec to 478688a Compare April 15, 2022 14:47
@akaihola akaihola force-pushed the chunks-from-black branch from 478688a to 3f1222c Compare April 24, 2022 19:53
@akaihola akaihola added this to the 1.6.0 milestone Apr 25, 2022
@akaihola akaihola force-pushed the chunks-from-black branch 3 times, most recently from 9af2dea to ff28a33 Compare August 28, 2022 19:43
Repository owner deleted a comment from sourcery-ai bot Aug 28, 2022
@akaihola akaihola mentioned this pull request Aug 29, 2022
Open
@akaihola akaihola force-pushed the chunks-from-black branch 2 times, most recently from 71bf232 to 1e9859b Compare August 30, 2022 06:23
@akaihola akaihola mentioned this pull request Sep 8, 2022
Open
@akaihola akaihola modified the milestones: 1.6.0, 1.7.0 Sep 17, 2022
@akaihola akaihola modified the milestones: 1.7.0, 1.8.0 Dec 28, 2022
akaihola and others added 4 commits January 5, 2023 14:50
@akaihola
Reimplement black.format_str as a line generator
16a98a9 
This is an experiment. Still concatenates the lines afterwards without making any
use of the extra information we could get.
@akaihola
Emit chunks of lines instead of individual lines
1e640ec 
This should allow us to get smaller diff chunks from Black than by
diffing and analyzing Black's string output for whole files.
@akaihola
'Refactored by Sourcery'
224500b
@akaihola
Satisfy Mypy with strange Black import
582fa74
@akaihola akaihola mentioned this pull request Dec 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@akaihola akaihola

Labels
enhancement New feature or request help wanted Extra attention is needed maybe invalid? Can't reproduce, or seems already fixed, or need more information
Projects
Darker and Graylint development
Status: No status
Milestone
Darker 3.1.0
Development

Successfully merging this pull request may close these issues.
1 participant
@akaihola