Pass schema object to processCode function #1196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epoberezkin
requested changes
Apr 27, 2020
| @@ -1169,7 +1169,7 @@ Defaults: | |||
| errorDataPath: 'object', // deprecated | |||
| messages: true, | |||
| sourceCode: false, | |||
| processCode: undefined, // function (str: string): string {} | |||
| processCode: undefined, // function (str: string, schema: object): string {} | |||
There was a problem hiding this comment.
Please also add comment in the lines 1281-2 below. require('js-beautify').js_beautify probably won't work anymore after this change, as it probably has some optional second parameter (it needs to be checked), so it has to be mentioned both in the docs and in the release notes what it has to be replaced with - not sure how many users would be affected... I am thinking to release over the next weekend to see if anything breaks. Alternatively it can be released on the beta branch in preparation for the next major version. I will think about it, but please add to the docs in any case.
|
thank you - I will release it on Saturday |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this pull request resolve?
This resolves #1194
What changes did you make?
I passed the schema to
processCodewhen it is callled,as well as updating the type definitions and README for
processCode.Is there anything that requires more attention while reviewing?
Nope.