Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hint and security annotations #5627

Merged

Conversation

andredcoliveira
Copy link
Contributor

@andredcoliveira andredcoliveira commented Aug 18, 2024

Issue #, if available:

  • N/A

Description of changes:

SVG HTML code:

<!-- hint: -->
<svg viewBox="0 0 20 16" xmlns="http://www.w3.org/2000/svg">
    <g stroke-width="2" stroke="blue" fill="none" shape-rendering="geometricPrecision">
        <path class="stroke-linejoin-round" d="M6 14H10"/>
        <path d="M8 11H9C9 9.47002 12 8.54002 12 5.76002C12.02 4.40002 11.39 3.36002 10.43 2.67002C9 1.64002 7.00001 1.64002 5.57001 2.67002C4.61001 3.36002 3.98 4.40002 4 5.76002C4 8.54002 7.00001 9.47002 7.00001 11H8Z"/>
    </g>
</svg>

<!-- security: -->
<svg viewBox="0 0 20 16" xmlns="http://www.w3.org/2000/svg">
    <g stroke-width="2" stroke="red" fill="none" shape-rendering="geometricPrecision">
        <path class="stroke-linejoin-round" d="M8 14.8307C8 14.8307 2 12.9047 2 8.08992V3.26548C5.31 3.26548 7.98999 1.34918 7.98999 1.34918C7.98999 1.34918 10.69 3.26548 14 3.26548V8.08992C14 12.9047 8 14.8307 8 14.8307Z"/>
        <path d="M2 8.08992V3.26548C5.31 3.26548 7.98999 1.34918 7.98999 1.34918"/>
        <path d="M13.99 8.08992V3.26548C10.68 3.26548 8 1.34918 8 1.34918"/>
        <path class="stroke-linejoin-round" d="M8 4V9"/>
        <path class="stroke-linejoin-round" d="M8 10V12"/>
    </g>
</svg>

<!-- security fold: -->
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 17 14" fill="none">
    <path d="M10.0001 13.6992C10.0001 13.6992 11.9241 13.4763 13 12.6992C14.4139 11.6781 16 10.5 16.1251 6.81126V2.58987C16.1251 2.54768 16.1221 2.50619 16.1164 2.46559V1.71485H15.2414L15.2307 1.71484L14.6251 1.69922V6.81123C14.6251 8.51061 14.6251 9.46461 12.7824 11.721C12.1586 12.4848 10.0001 13.6992 10.0001 13.6992Z" fill="crimson" stroke-width="2"/>
    <path fill-rule="evenodd" clip-rule="evenodd" d="M7.33609 0.367475C7.03214 0.152652 6.62548 0.153614 6.32253 0.369997L6.30869 0.379554C6.29553 0.388588 6.27388 0.403266 6.24417 0.422789C6.18471 0.46186 6.09321 0.520171 5.97313 0.591373C5.73251 0.734059 5.3799 0.926864 4.94279 1.12009C4.06144 1.5097 2.87541 1.88377 1.58984 1.88377H0.714844V2.75877V6.98015C0.714844 9.49374 2.28866 11.1973 3.70254 12.2185C4.41845 12.7355 5.12874 13.1053 5.65733 13.3457C5.92284 13.4664 6.14566 13.5559 6.30465 13.6161C6.38423 13.6462 6.44805 13.669 6.49349 13.6848C6.51622 13.6927 6.53438 13.6989 6.54764 13.7033L6.56382 13.7087L6.56908 13.7104L6.57099 13.711L6.83984 13.7533L6.57242 13.7115C6.74633 13.7673 6.93335 13.7673 7.10727 13.7115L7.1087 13.711L7.11061 13.7104L7.11587 13.7087L7.13205 13.7033C7.14531 13.6989 7.16346 13.6927 7.18619 13.6848C7.23164 13.669 7.29546 13.6462 7.37503 13.6161C7.53403 13.5559 7.75685 13.4664 8.02236 13.3457C8.55095 13.1053 9.26123 12.7355 9.97715 12.2185C11.391 11.1973 12.9648 9.49377 12.9648 6.98018V2.7588C12.9648 2.7166 12.9619 2.67511 12.9561 2.63451V1.88377H12.0811C12.0775 1.88377 12.074 1.88377 12.0704 1.88377C10.7979 1.88004 9.61962 1.51102 8.73894 1.12486C8.73534 1.12327 8.73174 1.12168 8.72814 1.12009C8.29103 0.926864 7.93842 0.734059 7.69779 0.591373C7.57772 0.520171 7.48622 0.46186 7.42676 0.422789C7.39705 0.403266 7.37539 0.388588 7.36224 0.379554L7.34896 0.37035C7.34896 0.37035 7.34847 0.37002 7.34563 0.374054L7.33779 0.368659L7.33609 0.367475ZM8.03471 2.72691C8.8604 3.09063 9.96066 3.46309 11.2061 3.58907V6.98015H11.2148C11.2148 8.67953 10.1637 9.92507 8.95254 10.7998C8.35595 11.2306 7.75374 11.5454 7.29796 11.7527C7.11671 11.8351 6.96062 11.8996 6.83984 11.9469C6.71906 11.8996 6.56297 11.8351 6.38173 11.7527C5.92595 11.5454 5.32373 11.2306 4.72715 10.7998C3.51603 9.92507 2.46484 8.67955 2.46484 6.98018V3.58909C3.71738 3.46239 4.82308 3.08639 5.65033 2.72071C6.14228 2.50324 6.54485 2.28537 6.83254 2.11624C7.12181 2.28535 7.527 2.50352 8.02196 2.72131C8.0262 2.72317 8.03045 2.72504 8.03471 2.72691ZM5.96484 3.40147V7.77647H7.71484V3.40147H5.96484ZM5.96484 10.4015V8.65147H7.71484V10.4015H5.96484Z" fill="crimson" stroke-width="2"/>
</svg>

GIF (may take a while to render):

ace_security_hint_with_fold

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Pull Request Checklist:

Copy link

codecov bot commented Aug 18, 2024

Codecov Report

Attention: Patch coverage is 99.44134% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.95%. Comparing base (0192880) to head (052a68b).
Report is 1 commits behind head on master.

Files Patch % Lines
src/mouse/default_gutter_handler.js 96.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5627      +/-   ##
==========================================
+ Coverage   86.91%   86.95%   +0.03%     
==========================================
  Files         594      594              
  Lines       43222    43348     +126     
  Branches     7155     7167      +12     
==========================================
+ Hits        37568    37694     +126     
  Misses       5654     5654              
Flag Coverage Δ
unittests 86.95% <99.44%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andredcoliveira andredcoliveira marked this pull request as draft August 19, 2024 09:48
@andredcoliveira andredcoliveira marked this pull request as ready for review August 19, 2024 15:03
@andredcoliveira andredcoliveira merged commit 8cef13f into ajaxorg:master Aug 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants