Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Contrast is too low for searched items #5523

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

nlujjawal
Copy link
Contributor

@nlujjawal nlujjawal commented Mar 29, 2024

Issue #, if available:

Description of changes:
In CloudEditor Dark Theme whenever a user searches for a term in the editor, the contrast for the searched items is too low which makes it hard to see the active search text and it's nearly impossible to view other searched text as contrast is too low.
So updated the colours for both above mentioned cases.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Pull Request Checklist:

ScreenShot Without new changes

Screenshot 2024-04-03 at 09 13 17

ScreenShot With new changes

Screenshot 2024-04-03 at 09 12 44

@nlujjawal nlujjawal self-assigned this Mar 29, 2024
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.60%. Comparing base (a66f861) to head (626dfea).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5523      +/-   ##
==========================================
+ Coverage   86.57%   86.60%   +0.02%     
==========================================
  Files         588      590       +2     
  Lines       42600    42705     +105     
  Branches     7071     7096      +25     
==========================================
+ Hits        36882    36985     +103     
- Misses       5718     5720       +2     
Flag Coverage Δ
unittests 86.60% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nlujjawal nlujjawal marked this pull request as ready for review April 3, 2024 07:47
@nlujjawal nlujjawal merged commit 507ae2f into master Apr 3, 2024
3 checks passed
@nlujjawal nlujjawal deleted the bug_fix_style_issues_searched_items branch April 3, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants