Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for 32-bit ARM assembly language #5484

Merged
merged 5 commits into from
Feb 21, 2024

Conversation

myriath
Copy link
Contributor

@myriath myriath commented Feb 19, 2024

Issue #, if available: NA

Description of changes:
Added support for 32-bit ARM assembly

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@marinsokol5
Copy link
Contributor

Hey, thanks for the submissions, looks great!

Is it possible to add this mode also to https://github.com/ajaxorg/ace/blob/master/src/ext/modelist.js#L55 and just give an example for easier verification and manual testing in the https://github.com/ajaxorg/ace/tree/master/demo/kitchen-sink/docs folder ?

You can find an example of this in #5483.

Added spsr register recognition
Fixed .asciiz recognition being seen after .ascii, missing the z
Renamed to ARM32 instead of just ARM
@myriath
Copy link
Contributor Author

myriath commented Feb 19, 2024

Hey, thanks for the submissions, looks great!

Is it possible to add this mode also to https://github.com/ajaxorg/ace/blob/master/src/ext/modelist.js#L55 and just give an example for easier verification and manual testing in the https://github.com/ajaxorg/ace/tree/master/demo/kitchen-sink/docs folder ?

You can find an example of this in #5483.

Alright, I just finished updating the modelist and the kitchen-sink doc. I also fixed a few issues with the highlighting I found.

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ffbb6b2) 86.52% compared to head (ba82ff9) 86.56%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5484      +/-   ##
==========================================
+ Coverage   86.52%   86.56%   +0.03%     
==========================================
  Files         584      588       +4     
  Lines       42410    42525     +115     
  Branches     7060     7067       +7     
==========================================
+ Hits        36696    36810     +114     
- Misses       5714     5715       +1     
Flag Coverage Δ
unittests 86.56% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@InspiredGuy InspiredGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@InspiredGuy InspiredGuy merged commit fb2d083 into ajaxorg:master Feb 21, 2024
3 checks passed
@myriath myriath deleted the assembly-arm branch February 21, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants