-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for 32-bit ARM assembly language #5484
Conversation
Hey, thanks for the submissions, looks great! Is it possible to add this mode also to https://github.com/ajaxorg/ace/blob/master/src/ext/modelist.js#L55 and just give an example for easier verification and manual testing in the https://github.com/ajaxorg/ace/tree/master/demo/kitchen-sink/docs folder ? You can find an example of this in #5483. |
Added spsr register recognition Fixed .asciiz recognition being seen after .ascii, missing the z Renamed to ARM32 instead of just ARM
Alright, I just finished updating the modelist and the kitchen-sink doc. I also fixed a few issues with the highlighting I found. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5484 +/- ##
==========================================
+ Coverage 86.52% 86.56% +0.03%
==========================================
Files 584 588 +4
Lines 42410 42525 +115
Branches 7060 7067 +7
==========================================
+ Hits 36696 36810 +114
- Misses 5714 5715 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Issue #, if available: NA
Description of changes:
Added support for 32-bit ARM assembly
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.