added ziglang support

[bajrangCoder]

Issue #, if available:
#5428

Description of changes:
added the zig mode and syntax higlighting and also a sample example for kitchen sink

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[marinsokol5]

Hey, thanks a lot for the contribution. 🤗
It looks good overall, I am not too familiar with this language but I tested it a bit in kitchen sink and it looks good.

The build is currently failing with:

/home/runner/work/ace/ace/src/mode/zig_highlight_rules.js
  92:21  error  Parsing error: Invalid regular expression: /\b(?<!\.)-?[\d_]+(?!\.)\b/: Invalid group

If we can take a look into that, we can merge it afterwards.

[bajrangCoder]

Yeah , soon I will fix it , give some time

It looks good overall, I am not too familiar with this
language but I tested it a bit in kitchen sink and it looks
good.

Yeah I am also not a zig developer 😅, I have written this with the help of vscode-zig and one sublime one

[bajrangCoder]

Fixed the issue .
Result of npm run lint

[whazor]

Hi, could you delete the commented code and delete the types/index.d.ts? For the rest it looks good to me.

[bajrangCoder]

Hi, could you delete the commented code and delete the types/index.d.ts? For the rest it looks good to me.

Done ✅

[bajrangCoder]

I don't have idea about why npm run cover fails . I have checked regex and they are working fine(I have tested it on kitchen sink). If anyone have idea about it then tell me, I will try my best to fix it. (@marinsokol5 , @whazor )

[whazor]

I also see these errors when opening the mode in the kitchen sink. These are the reported rules that give errors:

[
  {
    "rule": {
      "token": "text",
      "regex": "(\\\\s*)(?=\\\\s*(?:[a-zA-Z_][\\\\w.]*|@\\\\\\".+\\\\\\")?)(\\\\s*)((?:!)?)(\\\\s*)([a-zA-Z_][\\\\w.]*|@\\\\\\".+\\\\\\")",
      "onMatch": null
    },
    "groupCount": 5
  },
  {
    "rule": {
      "token": "text",
      "regex": "(\\\\s*)((?:[a-zA-Z_][\\\\w.]*|@\\\\\\".+\\\\\\")?)((?:!)?)(\\\\s*)(?:([a-zA-Z_][\\\\w.]*|@\\\\\\".+\\\\\\")\\\\b(?!\\\\s*\\\\\\\\())?)",
      "onMatch": null
    },
    "groupCount": 6
  }
]

[bajrangCoder]

why this error ? due to any wrong regex or anything else?

[whazor]

The first rule (\s*)(?=\s*(?:[a-zA-Z_][\w.]*|@\".+\")?)(\s*)((?:!)?)(\s*)([a-zA-Z_][\w.]*|@\".+\") has 5 regex groups ( ... ) but you specified 6 classes:

"text",
"storage.type.zig",
"text",
"keyword.operator.zig",
"text",
"storage.type.zig"

The second rule (\s*)((?:[a-zA-Z_][\w.]*|@\".+\")?)((?:!)?)(\s*)(?:([a-zA-Z_][\w.]*|@\".+\")\b(?!\s*\\())?) has 6 regex groups, but you specified 5 classes:

"text",
"storage.type.zig",
"keyword.operator.zig",
"text",
"storage.type.zig"

The regex is a bit too complicated for me to read, so I cannot see what would be the correct order of classes.

[bajrangCoder]

@whazor thanks for pointing out the problem!
Let me try to fix this ...

[bajrangCoder]

@whazor I have fixed the regex issue

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c216ef4) 87.59% compared to head (d202d5d) 86.50%.
Report is 25 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5429      +/-   ##
==========================================
- Coverage   87.59%   86.50%   -1.09%     
==========================================
  Files         584      584              
  Lines       46408    42376    -4032     
  Branches     7021     7055      +34     
==========================================
- Hits        40650    36657    -3993     
+ Misses       5758     5719      -39     

Flag	Coverage Δ
unittests	86.50% <100.00%> (-1.09%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bajrangCoder]

@whazor still there is problem?

[whazor]

LGTM, I think we can ignore code coverage for language modes