Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: command bar command type #5168

Merged
merged 2 commits into from
May 13, 2023
Merged

fix: command bar command type #5168

merged 2 commits into from
May 13, 2023

Conversation

akoreman
Copy link
Contributor

fix type to be consistent with ace.d.ts

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3f29428) 86.95% compared to head (5a4c64d) 86.95%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5168   +/-   ##
=======================================
  Coverage   86.95%   86.95%           
=======================================
  Files         562      562           
  Lines       44997    44997           
  Branches     6921     6921           
=======================================
  Hits        39128    39128           
  Misses       5869     5869           
Flag Coverage Δ
unittests 86.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/ext/command_bar.js 96.30% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@akoreman akoreman changed the title Type fix command bar tooltip fix: command bar command type May 12, 2023
@akoreman akoreman merged commit 64c8253 into ajaxorg:master May 13, 2023
@akoreman akoreman deleted the type_fix branch May 13, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants