Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom parentNode for hover tooltips #5156

Merged
merged 4 commits into from
May 10, 2023

Conversation

whazor
Copy link
Contributor

@whazor whazor commented May 5, 2023

Issue #, if available: n/a

Description of changes:
Just like tooltips, we allow custom parent nodes such that the hover tooltip could also be added to Ace editor instead of document body.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Patch coverage: 75.00% and no project coverage change.

Comparison is base (5f2face) 86.94% compared to head (0d5c90e) 86.94%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5156   +/-   ##
=======================================
  Coverage   86.94%   86.94%           
=======================================
  Files         560      560           
  Lines       44220    44220           
  Branches     6854     6854           
=======================================
  Hits        38446    38446           
  Misses       5774     5774           
Flag Coverage Δ
unittests 86.94% <75.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/tooltip.js 89.67% <75.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@whazor whazor requested a review from akoreman May 10, 2023 07:45
@whazor whazor merged commit 5f2e7d1 into ajaxorg:master May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants