Properly check for split transitions with attributes.

PiperOrigin-RevId: 475314064 Change-Id: Ib331d875c7483debfe6ebca5bf7c32f031ffdecd
aiuto · Oct 12, 2022 · a24183c · a24183c
1 parent 9677838
commit a24183c
Showing 1 changed file with 9 additions and 4 deletions.
diff --git a/src/main/java/com/google/devtools/build/lib/analysis/starlark/StarlarkAttrModule.java b/src/main/java/com/google/devtools/build/lib/analysis/starlark/StarlarkAttrModule.java
@@ -218,10 +218,15 @@ && containsNonNoneKey(arguments, ALLOW_SINGLE_FILE_ARG)) {
 
     if (containsNonNoneKey(arguments, CONFIGURATION_ARG)) {
       Object trans = arguments.get(CONFIGURATION_ARG);
-      boolean isSplit =
-          trans instanceof SplitTransition
-              || trans instanceof TransitionFactory
-              || trans instanceof StarlarkDefinedConfigTransition;
+      boolean isSplit = false;
+      if (trans instanceof SplitTransition || trans instanceof StarlarkDefinedConfigTransition) {
+        isSplit = true;
+      } else if (trans instanceof TransitionFactory) {
+        TransitionFactory<?> tf = (TransitionFactory<?>) trans;
+        if (tf.isSplit()) {
+          isSplit = true;
+        }
+      }
       if (isSplit && defaultValue instanceof StarlarkLateBoundDefault) {
         throw Starlark.errorf(
             "late-bound attributes must not have a split configuration transition");