Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

valToStrへのtype 'return'の文字列追加 #268

Closed
tai-cha opened this issue May 12, 2023 · 2 comments · Fixed by #844 · May be fixed by #269
Closed

valToStrへのtype 'return'の文字列追加 #268

tai-cha opened this issue May 12, 2023 · 2 comments · Fixed by #844 · May be fixed by #269
Labels
interpreter

Comments

@tai-cha
Copy link
Contributor

tai-cha commented May 12, 2023

PlaygroundやMisskey内のスクラッチパッドで最後に評価されたものが出力される機能があるがreturnを使った場合は必ずreturn<null>になってしまう

Playground、MisskeyのスクラッチパッドはどちらもutillのvalToStrを利用しているようなのでreturnに対してlabelなど設定すればよさそう

simpleの時は返す値をそのまま、そうでなければ return<任意のvalue文字列>になるような挙動でよさそうなら手元で試したものがあるのでPRにします
@tai-cha tai-cha changed the title return のvalToStrの追加 valToStrへのtype returnの文字列追加 May 12, 2023
@tai-cha tai-cha changed the title valToStrへのtype returnの文字列追加 valToStrへのtype 'return'の文字列追加 May 12, 2023
tai-cha added a commit to tai-cha/aiscript that referenced this issue May 12, 2023
@tai-cha
feat: Add return str (aiscript-dev#268)
90549d6
@tai-cha tai-cha mentioned this issue May 12, 2023
Draft
@salano-ym
Copy link
Member

returnが残らないようにするのが根本的解決かも？ #237

@tai-cha
Copy link
Contributor Author

tai-cha commented May 13, 2023

ブロック内以外のreturnも値のほうが表示されて欲しさはあるような…？

@FineArchs FineArchs mentioned this issue May 28, 2023
Closed
@ikasoba ikasoba added the enhancement New feature or request label Aug 30, 2023
@marihachi marihachi added interpreter and removed enhancement New feature or request labels Oct 13, 2023
@takejohn takejohn mentioned this issue Nov 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
interpreter
Projects
None yet
Milestone
No milestone
4 participants
@marihachi @tai-cha @salano-ym @ikasoba