Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-pennylane contribution from remilapeyre #52596

Conversation

remilapeyre
Copy link
Contributor

What

This PR updates source Pennylane (source-pennylane).

The contributor provided the following description of the change:

Remove support for incremental sync to category groups because does not return an updated_at field in the response and does not support it in the query params.

Also fix the primary key for plan_items.

Reviewer checklist

  • Resolve any merge conflicts and validate file diffs (make sure the PR only includes changes intended by the contributor)
  • After reviewing the changes, run the bump-version Airbyte-CI command locally to update the version of the connector according to the versioning guidelines. Add breakingChanges to metadata if necessary.
  • Ensure connector docs are up to date with any changes
  • Run /format-fix to resolve any formatting errors
  • Click into the CI workflows that wait for a maintainer to run them, which should trigger CI runs

Copy link

vercel bot commented Jan 28, 2025

@remilapeyre is attempting to deploy a commit to the Airbyte Growth Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@natikgadzhi natikgadzhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preparing this to ship — approving pending green CI. I'll need to bump version in a bit, too.

@natikgadzhi
Copy link
Contributor

natikgadzhi commented Jan 28, 2025

/bump-version type="minor" changelog="Fixes for category_groups and plan_items"

Bump Version job started... Check job output.

🔴 Job completed successfully (no changes, this is sus).

Copy link

vercel bot commented Jan 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 6:21pm

@natikgadzhi natikgadzhi merged commit 2c5b7e0 into airbytehq:master Jan 29, 2025
24 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/pennylane
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants