Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(airbyte-ci): Delete broken or unused commands #52558

Merged
merged 5 commits into from
Jan 30, 2025

Conversation

natikgadzhi
Copy link
Contributor

@natikgadzhi natikgadzhi commented Jan 27, 2025

What

Time to clean up some of Airbyte CI:

  • update-to-base-image: we only have 4 connectors left
  • update-to-poetry: same
  • update-to-logging-logger: same
  • airbyte-ci format: time to fully remove

How

We should bundle those flows together, and then release airbyte-ci 5.0 without them, so that we group most breaking changes in a major version release.

Follow-ups

  • Remove support for setup.py in airbyte-ci connectors build and test

Copy link

vercel bot commented Jan 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 0:50am

@natikgadzhi natikgadzhi marked this pull request as ready for review January 30, 2025 00:38
@natikgadzhi natikgadzhi requested a review from a team as a code owner January 30, 2025 00:38
@natikgadzhi natikgadzhi enabled auto-merge (squash) January 30, 2025 00:39
@natikgadzhi
Copy link
Contributor Author

I'm only starting to test this — I expect things to blow up at first

Copy link
Collaborator

@aaronsteers aaronsteers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! No idea though if/how we test but I'm on board for yolo if needed.

@natikgadzhi natikgadzhi merged commit 5dfb62a into master Jan 30, 2025
26 checks passed
@natikgadzhi natikgadzhi deleted the ng/airbyte-ci/delete-migrate-to-base-image branch January 30, 2025 03:14
@natikgadzhi
Copy link
Contributor Author

Note: there's a follow-up item to cut a new breaking Airbyte CI release for this.

@natikgadzhi
Copy link
Contributor Author

Potentially a good idea to rip out setup.py support at the same time, but I don't care enough about semantics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants