Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airbyte-ci: don't require extra permissions or --is-ci flag to upload reports to GCS bucket #48824

Merged
merged 2 commits into from
Dec 5, 2024
Merged

airbyte-ci: don't require extra permissions or --is-ci flag to upload reports to GCS bucket #48824

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c491293
don't require "is_ci" flag to upload reports to gcs bucket
aaronsteers Dec 5, 2024
def2041
chore: add version bump and changelog
aaronsteers Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-ci/connectors/pipelines/pipelines/models/contexts/pipeline_context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ def dagger_cloud_url(self) -> Optional[str]:

@property
def remote_storage_enabled(self) -> bool:
return self.is_ci and bool(self.ci_report_bucket) and bool(self.ci_gcp_credentials)
return bool(self.ci_report_bucket) and bool(self.ci_gcp_credentials)

def _should_send_status_check(self) -> bool:
should_send = self.is_pr or any(
Expand Down
Loading