feat(airbyte-cdk): add custom decoder #48450
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
maxi297
reviewed
Nov 11, 2024
| type: string | ||
| additionalProperties: true | ||
| examples: | ||
| - "source_amazon_ads.components.GzipJsonlDecoder" |
There was a problem hiding this comment.
Why not put this in the CDK? It feels like an interesting pattern that could be composed (for example, GZIP with JSONL or GZIP with CSV)
There was a problem hiding this comment.
Amazon ads has some specific decompress with utf :
I can add a GzipJsonDecoder with optional encoding field (I guess it would be utf-8 by default). WDYT?
There was a problem hiding this comment.
This makes sense to me, thanks @artem1205 !
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
|
moved to airbytehq/airbyte-python-cdk#20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
resolving amazon ads low-code async migration
add custom decoder to implement gzip jsonl decoder
How
add custom decoder
Review guide
airbyte-cdk/python/airbyte_cdk/sources/declarative/declarative_component_schema.yamlairbyte-cdk/python/airbyte_cdk/sources/declarative/models/declarative_component_schema.pyairbyte-cdk/python/airbyte_cdk/sources/declarative/parsers/model_to_component_factory.pyUser Impact
Can this PR be safely reverted and rolled back?