Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(airbyte-cdk): remove codeflash to reduce repo noise #46727

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

natikgadzhi
Copy link
Contributor

@natikgadzhi natikgadzhi commented Oct 10, 2024

What

  • Removes codeflash gh workflow
  • Removes codeflash CDK dependency

Closes #46726

@natikgadzhi natikgadzhi requested a review from a team as a code owner October 10, 2024 23:47
Copy link

vercel bot commented Oct 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Oct 10, 2024 11:48pm

@natikgadzhi natikgadzhi requested a review from girarda October 10, 2024 23:48
@natikgadzhi natikgadzhi enabled auto-merge (squash) October 10, 2024 23:48
@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Oct 10, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we think that we'll eventually re-enable codeflash I suggest manually disabling the workflow in the GHA https://github.com/airbytehq/airbyte/actions/workflows/cdk-codeflash.yml

@natikgadzhi natikgadzhi disabled auto-merge October 11, 2024 19:20
@natikgadzhi
Copy link
Contributor Author

Overriding and merging because the changes here are not related to the code, so failing connector tests are not related.

@natikgadzhi natikgadzhi merged commit b9f4154 into master Oct 11, 2024
30 of 34 checks passed
@natikgadzhi natikgadzhi deleted the ng/unflash branch October 11, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CDK Connector Development Kit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove codeflash from gh actions and codebase
3 participants