Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Source Chargebee: add missing incremental dependency to full-refresh sub-streams with Incremental parent streams #46343

Merged
merged 2 commits into from
Oct 3, 2024
Merged

🐛 Source Chargebee: add missing incremental dependency to full-refresh sub-streams with Incremental parent streams #46343

merged 2 commits into from
Oct 3, 2024

Conversation

bazarnov
Copy link
Collaborator

@bazarnov bazarnov commented Oct 3, 2024 •
edited
Loading

What

Resolving:

Story:

  • The missing incremental dependency for CDK 5.8.0, for cases when substream is full-refresh and the parent stream is incremental causing the source to read all of the parent records first and then yield them to substream, which itself causes the heartbeat issues for the Platform.

How

  • Added incremental_dependency: true to the next streams:
    • contact
    • attached_item_stream
    • quote_line_group_stream

User Impact

No impact is expected, for the existing Customers.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@bazarnov bazarnov self-assigned this Oct 3, 2024
@vercel Vercel
Copy link

vercel bot commented Oct 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 2:49pm

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Oct 3, 2024
@bazarnov bazarnov requested a review from tolik0 October 3, 2024 14:45
@bazarnov bazarnov enabled auto-merge (squash) October 3, 2024 14:50
@bazarnov bazarnov disabled auto-merge October 3, 2024 14:54
@bazarnov bazarnov merged commit bc093d8 into master Oct 3, 2024
36 checks passed
@bazarnov bazarnov deleted the baz/source/chargebee/update-streams-with-incremental-dependency branch October 3, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolik0 tolik0 tolik0 approved these changes

Assignees

@bazarnov bazarnov

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/chargebee
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bazarnov @tolik0 @octavia-squidington-iii