✨ feat(Source sftp-bulk): upgrade to CDK 5 #46323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
aldogonzalez8
commented
Oct 3, 2024
Comment on lines
+26
to
+36
| with pytest.raises(AirbyteTracedException) as exc_info: | ||
| SourceSFTPBulk(catalog=configured_catalog, config=invalid_config, state=None).check(logger, invalid_config) | ||
|
|
||
| assert exc_info.value.failure_type.value == FailureType.config_error.value | ||
|
|
||
|
|
||
| def test_check_invalid_config(configured_catalog: ConfiguredAirbyteCatalog, config: Mapping[str, Any]): | ||
| invalid_config = config | {"credentials": {"auth_type": "password", "password": "wrongpass"}} | ||
| outcome = SourceSFTPBulk(catalog=configured_catalog, config=invalid_config, state=None).check(logger, invalid_config) | ||
| assert outcome.status == Status.FAILED | ||
| with pytest.raises(AirbyteTracedException) as exc_info: | ||
| SourceSFTPBulk(catalog=configured_catalog, config=invalid_config, state=None).check(logger, invalid_config) | ||
| assert exc_info.value.failure_type.value == FailureType.config_error.value |
There was a problem hiding this comment.
airbyte exceptions are now caught here, so it is ok to change the test a little bit as we don't call the entry point but directly the check method in the source.
bazarnov
approved these changes
Oct 3, 2024
lazebnyi
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
We will make changes in source-sftp-bulk that will leverage CDK; then I'm upgrading to the latest version to have a base to work.
How
Upgrade CDK and update a couple of tests; airbyte exceptions are now caught here, so it is ok to change the test a little bit as we don't call the entry point but directly the check method in the source.
Review guide
User Impact
No direct user impact, but this will helo with transfer file project.
Can this PR be safely reverted and rolled back?