java-cdks: update all libraries #45432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
This was referenced Sep 12, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @stephane-airbyte and the rest of your teammates on |
This was referenced Sep 12, 2024
21c91c5 to
10105cc
Compare
ad5f040 to
e17ac80
Compare
This was referenced Sep 12, 2024
10105cc to
83e2dda
Compare
e17ac80 to
943e315
Compare
83e2dda to
88fd78e
Compare
943e315 to
2c0f5d9
Compare
88fd78e to
1601c23
Compare
2c0f5d9 to
2f07bd7
Compare
1601c23 to
a607474
Compare
2f07bd7 to
b07a991
Compare
2 tasks
a52c275 to
372f581
Compare
c35540c to
6d74db7
Compare
0524954 to
0845cbe
Compare
0845cbe to
92d2f4f
Compare
postamar
reviewed
Sep 18, 2024
| implementation 'org.openapi4j:openapi-schema-validator:1.0.7' | ||
|
|
||
| runtimeOnly 'com.google.guava:guava:33.2.0-jre' | ||
| runtimeOnly 'org.apache.commons:commons-compress:1.26.1' | ||
| runtimeOnly 'com.google.guava:guava:33.3.0-jre' |
There was a problem hiding this comment.
Watch out for these. These, I think but I'm not sure, are here to turn transitive dependencies into runtime-only. There's no point in using Guava in a Kotlin codebase.
I really should have commented their purpose, because now I can't really remember any more!
There was a problem hiding this comment.
I'll find out what their purpose is and will report back shortly.
There was a problem hiding this comment.
These two runtimeOnly dependencies exist because of the exclusions defined for airbyte-protocol. Can you add a comment to this effect please?
In any case bumping their versions is fine.
postamar
approved these changes
Sep 18, 2024
rodireich
approved these changes
Sep 18, 2024
johnny-schmidt
approved these changes
Sep 18, 2024
92d2f4f to
c375d1e
Compare
c375d1e to
2282aa3
Compare
|
/publish-java-cdk
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades various library dependencies across multiple modules in the Airbyte CDK. It includes updates to Jackson, Guava, Apache Commons, Log4j, Kotlin coroutines, TestContainers, and other libraries.