[CDK] Always use lower cases for error message regex matching in error translation #44832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -145,7 +145,7 @@ open class ConnectorExceptionHandler { | |||
| open fun translateConnectorSpecificErrorMessage(e: Throwable?): String? { | |||
| if (e == null) return null | |||
| for (error in connectorErrorDictionary) { | |||
| if (e.message?.lowercase()?.matches(error.regexMatchingPattern.toRegex())!!) | |||
| if (e.message?.lowercase()?.matches(error.regexMatchingPattern.lowercase().toRegex())!!) | |||
There was a problem hiding this comment.
rather than doing that, I'd rather store a pattern in the error object, and compile it with compilePattern(CASE_INSENSITIVE)
There was a problem hiding this comment.
good idea! fixed, please take another look. thanks!
|
/publish-java-cdk force=true
|
stephane-airbyte
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #44439
Need to bump the certified connector to use it in the next.
Can this PR be safely reverted and rolled back?