airbyte-ci: ignore archived connectors #43426
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @alafanechere and the rest of your teammates on |
1f396ae to
2b14192
Compare
2b14192 to
cd478ea
Compare
There was a problem hiding this comment.
Curious: it looks like this change only excludes archived connectors form --modified selection? Is that the intent? (unblocking in case it is).
I assume airbyte-ci connectors --support-level archived would work to select them as well?
Left one ask, but overall this seems like a good step. Let's add the help message clarification!
| @@ -27,6 +27,9 @@ def _find_modified_connectors( | |||
| modified_connectors = set() | |||
|
|
|||
| for connector in all_connectors: | |||
| if connector.support_level == "archived": | |||
| main_logger.info(f"Skipping connector '{connector}' due to 'archived' support level.") | |||
There was a problem hiding this comment.
Ask: let's add that caveat to the help message of the --modified flag.
Yes the indent is to only deselect them on automatic selection with --modified. Others explicit (and likely local) execution with --name or --support-level will still allow selecting archived connectors |
25d874b to
483e875
Compare
483e875 to
51cec4c
Compare
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
What
Closes https://github.com/airbytehq/airbyte-internal-issues/issues/8942
This change means we won't auto select any archived connectors to run
connectorssubcommand like publish and test.Archived connectors could still be selected with explicit
--nameoption, but they won't be selected according to file modification when using--modified.This is to avoid publishing (and testing) archived connectors.