fix(source-google-ads): fix attribute error on check connection #42971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
/approve-regression-tests
|
bazarnov
approved these changes
Aug 2, 2024
| @@ -225,6 +225,8 @@ def check_connection(self, logger: logging.Logger, config: Mapping[str, Any]) -> | |||
| customer_id=customer.id, | |||
| login_customer_id=customer.login_customer_id, | |||
| ) | |||
| except AirbyteTracedException as e: | |||
| raise e | |||
There was a problem hiding this comment.
I'm a little bit worried about losing the underlying context here, probably we should raise something like:
raise e from eBut if it is OK, and we don't lose the context of the AirbyteTracedException raised prior, we should be fine with this.
There was a problem hiding this comment.
Thanks, updated
|
/approve-regression-tests
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
resolved: https://github.com/airbytehq/oncall/issues/6141
How
We should handle AirbyteTracedException on check separate from Google Ads Exception to avoid attribute error when AirbyteTracedException is passed to traced_exception method.
Review guide
User Impact
Can this PR be safely reverted and rolled back?