cdk-java: wait until after table migration before creating the WriteConfig objects #42015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
This was referenced Jul 16, 2024
2 tasks
2 tasks
6523058 to
469d023
Compare
18f7126 to
2103175
Compare
This was referenced Jul 17, 2024
469d023 to
ac23891
Compare
2103175 to
f5deaa2
Compare
edgao
approved these changes
Jul 17, 2024
| ) | ||
| } | ||
| val writeConfigs = mutableListOf<WriteConfig>() |
There was a problem hiding this comment.
Suggested change
| val writeConfigs = mutableListOf<WriteConfig>() | |
| // This list is populated when the OnStartFunction is invoked | |
| // which is OK, because it's only used by the flush function | |
| // which never runs until after OnStart runs | |
| val writeConfigs = mutableListOf<WriteConfig>() |
( 😢 )
| @@ -145,11 +145,14 @@ object JdbcBufferedConsumerFactory { | |||
| private fun onStartFunction( | |||
There was a problem hiding this comment.
what do you think of having this function return a Pair<OnStartFunction, List<WriteConfig>>?
fun onStartFunction(): Pair<OnStartFunction, List<WriteConfig>> {
val writeConfigs = mutableList()
val onStartFunction = OnStartFunction { ... populate writeConfigs.... }
return Pair(onStartFunction, writeConfigs)
}and then in createAsync, we don't need to create a mutable list manually:
val (onStartFunction, writeConfigs) = onStartFunction(...)
return AsyncStreamConsumer(
outputRecordCollector,
onStartFunction,
JdbcFlushFunction(...writeConfigs...)
...
)
This was referenced Jul 18, 2024
Merge activity
|
ac23891 to
8891c0b
Compare
f5deaa2 to
d489ef3
Compare
8891c0b to
6893cd7
Compare
d489ef3 to
a14e7b8
Compare
6893cd7 to
c6bb2ed
Compare
a14e7b8 to
f42201e
Compare
f42201e to
f93854a
Compare
xiaohansong
pushed a commit
that referenced
this pull request
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
How
Review guide
User Impact
Can this PR be safely reverted and rolled back?