Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(source-iterable): fix OOM errors #41983

Merged
merged 11 commits into from
Jul 22, 2024
Merged

Conversation

artem1205
Copy link
Collaborator

@artem1205 artem1205 commented Jul 16, 2024

What

How

  • migrate to CDK v3
  • use JsonlDecoder
  • use IterableDecoder

Review guide

  1. airbyte-integrations/connectors/source-iterable/source_iterable/manifest.yaml
  2. airbyte-integrations/connectors/source-iterable/source_iterable/components.py

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Copy link

vercel bot commented Jul 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jul 22, 2024 10:17am

[skip CI]

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
[skip CI]

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
@artem1205 artem1205 marked this pull request as ready for review July 19, 2024 13:31
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
@artem1205 artem1205 requested a review from a team July 19, 2024 13:52
…205/source-iterable-5643

# Conflicts:
#	airbyte-integrations/connectors/source-iterable/metadata.yaml
#	airbyte-integrations/connectors/source-iterable/poetry.lock
#	airbyte-integrations/connectors/source-iterable/pyproject.toml
#	docs/integrations/sources/iterable.md
[skip ci]

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
@artem1205 artem1205 merged commit bc0b9b9 into master Jul 22, 2024
34 checks passed
@artem1205 artem1205 deleted the artem1205/source-iterable-5643 branch July 22, 2024 10:31
xiaohansong pushed a commit that referenced this pull request Jul 23, 2024
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/iterable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants