Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

null safety in debezium to airbyte message generation #41622

Merged
merged 10 commits into from
Jul 23, 2024
Merged

null safety in debezium to airbyte message generation #41622

merged 10 commits into from
Jul 23, 2024

Conversation

rodireich
Copy link
Contributor

@rodireich rodireich commented Jul 11, 2024 •
edited by theyueli
Loading

What

Fixes #41620

Fix null safety in java to kotlin code causing debezium event processing error if a "before" node is missing on the change event.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@rodireich rodireich linked an issue Jul 11, 2024 that may be closed by this pull request
Debezium events missing a "before" node crashes source-postgres #41620
Closed
1 task
@vercel Vercel
Copy link

vercel bot commented Jul 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jul 23, 2024 6:23am

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation CDK Connector Development Kit connectors/source/postgres labels Jul 11, 2024
@rodireich rodireich requested a review from theyueli July 11, 2024 06:43
@rodireich rodireich marked this pull request as ready for review July 11, 2024 06:43
@rodireich rodireich requested review from a team as code owners July 11, 2024 06:43
theyueli
theyueli approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@theyueli theyueli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@rodireich
Copy link
Contributor Author

I applied a dev build on the affected workspace which helped uncover the root cause.
(we should still put this fix in as null safety issue existed and masked the root cause here)

@rodireich rodireich mentioned this pull request Jul 11, 2024
Closed
1 task
johnny-schmidt
johnny-schmidt reviewed Jul 12, 2024
View reviewed changes
airbyte-integrations/connectors/source-postgres/build.gradle Outdated
features = ['db-sources', 'datastore-postgres']
useLocalCdk = false
useLocalCdk = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this intentional or done for testing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to reply - sorry
This is the usual way of operation when making changes in CDK.
Until that CDK is published as a new version, the connector needs to consume a locally built CDK.
Once you publish a CDK we change this back to false ahead of merging.

@rodireich
Copy link
Contributor Author

rodireich commented Jul 23, 2024 •
edited by github-actions bot
Loading

/publish-java-cdk

🕑 https://github.com/airbytehq/airbyte/actions/runs/10053731028
✅ Successfully published Java CDK version=0.43.1!

@rodireich rodireich merged commit 250c02d into master Jul 23, 2024
34 checks passed
@rodireich rodireich deleted the 41620-debezium-events-missing-a-before-node-crashes-source-postgres branch July 23, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnny-schmidt johnny-schmidt johnny-schmidt left review comments

@theyueli theyueli theyueli approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation CDK Connector Development Kit connectors/source/postgres
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Debezium events missing a "before" node crashes source-postgres
4 participants
@rodireich @theyueli @johnny-schmidt @octavia-squidington-iii