Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Source Google Analytics (Universal Analytics): disable connectors #40244

Merged

Conversation

maxi297
Copy link
Contributor

@maxi297 maxi297 commented Jun 24, 2024

What

The API will be deprecated on July 1st. We need to:

  • Deprecate the connector
  • Prevent the connector from sending alerts

How

  • Setting the registries.x.enabled to false
  • Have the main.py just break with a config error
    • Note that I did not remove the code which could be confusing for future dev. We can do that if we see value in it. Else, I would wait for us to rm -rf source-google-analytics-v4

The outcome looks likes this:

(.venv) source-google-analytics-v4% python main.py spec
{"type": "SPEC", "spec": {"connectionSpecification": {}}}

(.venv) source-google-analytics-v4% python main.py check --config secrets/config.json
{"type": "LOG", "log": {"level": "FATAL", "message": "Google Analytics Universal Analytics Source Connector will be deprecated due to the deprecation of the Google Analytics Universal Analytics API by Google. This deprecation is scheduled by Google on July 1, 2024 (see Google\u2019s Documentation for more details). Transition to the Google Analytics 4 (GA4) Source Connector by July 1, 2024, to continue accessing your analytics data.\nTraceback (most recent call last):\n  File \"/Users/maxime/devel/code/airbyte/airbyte-integrations/connectors/source-google-analytics-v4/main.py\", line 22, in <module>\n    raise AirbyteTracedException(\nairbyte_cdk.utils.traced_exception.AirbyteTracedException: Google Analytics Universal Analytics Source Connector will be deprecated due to the deprecation of the Google Analytics Universal Analytics API by Google. This deprecation is scheduled by Google on July 1, 2024 (see Google\u2019s Documentation for more details). Transition to the Google Analytics 4 (GA4) Source Connector by July 1, 2024, to continue accessing your analytics data."}}
{"type": "TRACE", "trace": {"type": "ERROR", "emitted_at": 1719341396169.7432, "error": {"message": "Google Analytics Universal Analytics Source Connector will be deprecated due to the deprecation of the Google Analytics Universal Analytics API by Google. This deprecation is scheduled by Google on July 1, 2024 (see Google\u2019s Documentation for more details). Transition to the Google Analytics 4 (GA4) Source Connector by July 1, 2024, to continue accessing your analytics data.", "internal_message": "Google Analytics Universal Analytics Source Connector will be deprecated due to the deprecation of the Google Analytics Universal Analytics API by Google. This deprecation is scheduled by Google on July 1, 2024 (see Google\u2019s Documentation for more details). Transition to the Google Analytics 4 (GA4) Source Connector by July 1, 2024, to continue accessing your analytics data.", "stack_trace": "Traceback (most recent call last):\n  File \"/Users/maxime/devel/code/airbyte/airbyte-integrations/connectors/source-google-analytics-v4/main.py\", line 22, in <module>\n    raise AirbyteTracedException(\nairbyte_cdk.utils.traced_exception.AirbyteTracedException: Google Analytics Universal Analytics Source Connector will be deprecated due to the deprecation of the Google Analytics Universal Analytics API by Google. This deprecation is scheduled by Google on July 1, 2024 (see Google\u2019s Documentation for more details). Transition to the Google Analytics 4 (GA4) Source Connector by July 1, 2024, to continue accessing your analytics data.\n", "failure_type": "config_error", "stream_descriptor": null}}}

User Impact

We intend to merge this late on Sunday. At that point:

  • The users won't be able to configure new Google Analytics (Universal Analytics) sources
  • Cloud users will be updated to the newest versions which will just raise the config error so no data will be synced
  • OSS users will still be able to run the syncs but this will most likely raise system_errors

Can this PR be safely reverted and rolled back?

  • YES 💚 (but we expect that the API Connectors oncall person will receive pager alerts)
  • NO ❌

Copy link

vercel bot commented Jun 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jun 30, 2024 10:43pm

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jun 24, 2024
@maxi297
Copy link
Contributor Author

maxi297 commented Jun 24, 2024

@girarda you will be the one to merge that. Do you have the almighty powers to ignore failed CI items?

EDIT: @girarda confirmed in-person that he had the almighty powers so we should be good

@maxi297
Copy link
Contributor Author

maxi297 commented Jun 24, 2024

@alafanechere is there a way to disable nightly builds so that we don't get notified in #connector-build-statuses

@alafanechere
Copy link
Contributor

@alafanechere is there a way to disable nightly builds so that we don't get notified in #connector-build-statuses

If you modify the support level from certified to community the connector won't be part of the nightly builds anymore.

@girarda
Copy link
Contributor

girarda commented Jun 30, 2024

/approve-and-merge reason="Deprecating Source Google Analytics (Universal Analytics)"

@octavia-approvington
Copy link
Contributor

Myomoto says it looks good
thats a niiice

@octavia-approvington octavia-approvington merged commit 58f67cb into master Jun 30, 2024
29 of 32 checks passed
@octavia-approvington octavia-approvington deleted the maxi297/remove-source-google-analytics-v4 branch June 30, 2024 23:48
Copy link

sentry-io bot commented Jul 1, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

Did you find this useful? React with a 👍 or 👎

xiaohansong pushed a commit that referenced this pull request Jul 9, 2024
…40244)

Co-authored-by: Alexandre Girard <alexandre@airbyte.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants