Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Source Google Analytics (Data API, a.k.a 4 (GA4) ) #39916

Merged
merged 2 commits into from
Jun 21, 2024
Merged

🐛 Source Google Analytics (Data API, a.k.a 4 (GA4) ) #39916

merged 2 commits into from
Jun 21, 2024

Conversation

bazarnov
Copy link
Collaborator

What

Resolving:

How

  • added the raise_exception_on_missing_stream to source.py to be able to ignore streams that present for the CATALOG, but missing for the input_configuration.custom_reports_array

User Impact

No impact is expected, just a patch.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@vercel Vercel
Copy link

vercel bot commented Jun 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2024 8:57am

@bazarnov bazarnov marked this pull request as ready for review June 21, 2024 08:53
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jun 21, 2024
@bazarnov bazarnov requested a review from a team June 21, 2024 08:56
@bazarnov bazarnov self-assigned this Jun 21, 2024
@bazarnov bazarnov enabled auto-merge (squash) June 21, 2024 08:57
@bazarnov bazarnov merged commit 6f48e7a into master Jun 21, 2024
38 checks passed
@bazarnov bazarnov deleted the baz/source/google-analytics-data-api-skip-missing-streams branch June 21, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darynaishchenko darynaishchenko darynaishchenko approved these changes

@artem1205 artem1205 artem1205 approved these changes

@tolik0 tolik0 tolik0 approved these changes

Assignees

@bazarnov bazarnov

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/google-analytics-data-api team/connectors-python
Projects
No open projects
GL Roadmap
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bazarnov @tolik0 @artem1205 @darynaishchenko @octavia-squidington-iii