Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(source-jira): update pk for workflows stream #39467

Merged
merged 10 commits into from
Jun 18, 2024

Conversation

darynaishchenko
Copy link
Collaborator

@darynaishchenko darynaishchenko commented Jun 13, 2024

What

cat: failed due to forbidden type(object) of pk in workflows stream

How

Updated pk from Id to composite entityId, name with valid type string.

Review guide

  1. airbyte-integrations/connectors/source-jira/source_jira/manifest.yaml
  2. airbyte-integrations/connectors/source-jira/source_jira/schemas/workflows.json
  3. docs/integrations/sources/jira-migrations.md

User Impact

Users will need to refresh schema and clear stream data.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@darynaishchenko darynaishchenko self-assigned this Jun 13, 2024
Copy link

vercel bot commented Jun 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 18, 2024 10:16am

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/jira labels Jun 13, 2024
@octavia-squidington-iv octavia-squidington-iv requested a review from a team June 13, 2024 17:10
@darynaishchenko darynaishchenko merged commit 555a607 into master Jun 18, 2024
33 checks passed
@darynaishchenko darynaishchenko deleted the daryna/source-jira/fix-pk branch June 18, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/jira
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants