Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destinations CDK: generation_id/sync_id plumbing #38358

Merged
merged 1 commit into from
May 29, 2024
Merged

Destinations CDK: generation_id/sync_id plumbing #38358

merged 1 commit into from
May 29, 2024

Conversation

edgao
Copy link
Contributor

@edgao edgao commented May 20, 2024 •
edited
Loading

  • Plumb sync ID + generation ID into the raw tables (all the CSV writer stuff, DefaultSyncOperation, etc.)
  • update DV2 test fixtures to exercise sync/generation id

@vercel Vercel
Copy link

vercel bot commented May 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview May 29, 2024 6:26pm

This was referenced May 20, 2024
Merged
Merged
Closed
Merged
Merged
Merged
Merged
@edgao Graphite App
Copy link
Contributor Author

edgao commented May 20, 2024 •
edited by gisripa
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @edgao and the rest of your teammates on Graphite Graphite

This was referenced May 20, 2024
Merged
Merged
@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label May 20, 2024
@gisripa gisripa force-pushed the gireesh/bq-refactor-new-intfs branch from f5006c0 to a64843a Compare May 20, 2024 19:12
@edgao edgao force-pushed the gireesh/bq-refactor-new-intfs branch from a64843a to 93e5f05 Compare May 20, 2024 20:24
@edgao edgao force-pushed the edgao/generation_id_in_cdk branch from 1290443 to 7b49601 Compare May 20, 2024 20:25
@gisripa gisripa force-pushed the gireesh/bq-refactor-new-intfs branch from 93e5f05 to 9cab662 Compare May 20, 2024 21:18
@edgao edgao force-pushed the gireesh/bq-refactor-new-intfs branch from 9cab662 to ae04fdc Compare May 20, 2024 22:26
@edgao edgao force-pushed the edgao/generation_id_in_cdk branch from 7b49601 to 0651902 Compare May 20, 2024 22:26
@gisripa gisripa force-pushed the gireesh/bq-refactor-new-intfs branch 3 times, most recently from 684022b to cfa11c6 Compare May 21, 2024 16:23
@edgao edgao force-pushed the gireesh/bq-refactor-new-intfs branch from cfa11c6 to 891944a Compare May 21, 2024 16:56
@edgao edgao force-pushed the edgao/generation_id_in_cdk branch from 0651902 to 8e7b892 Compare May 21, 2024 16:56
@gisripa gisripa force-pushed the gireesh/bq-refactor-new-intfs branch 3 times, most recently from 796002e to abdfe71 Compare May 21, 2024 21:11
@edgao edgao force-pushed the gireesh/bq-refactor-new-intfs branch from abdfe71 to 891944a Compare May 21, 2024 21:56
@edgao edgao force-pushed the edgao/generation_id_in_cdk branch from 8e7b892 to 5593756 Compare May 21, 2024 21:56
@edgao edgao force-pushed the gireesh/bq-refactor-new-intfs branch from 891944a to aa20464 Compare May 21, 2024 22:01
@edgao edgao force-pushed the edgao/generation_id_in_cdk branch from 5593756 to fded86d Compare May 21, 2024 22:02
@gisripa gisripa requested a review from a team May 22, 2024 21:40
@gisripa gisripa requested a review from a team as a code owner May 22, 2024 21:40
Base automatically changed from gireesh/bq-refactor-new-intfs to master May 22, 2024 22:34
@edgao edgao force-pushed the edgao/generation_id_in_cdk branch from e291274 to b7dae03 Compare May 23, 2024 14:50
This was referenced May 23, 2024
Merged
Merged
@edgao edgao force-pushed the edgao/generation_id_in_cdk branch from b7dae03 to 6daa73d Compare May 24, 2024 21:00
@edgao edgao mentioned this pull request May 28, 2024
Merged
2 tasks
@edgao edgao force-pushed the edgao/generation_id_in_cdk branch 2 times, most recently from f797a95 to 942ef3a Compare May 28, 2024 21:18
@edgao edgao changed the base branch from master to gireesh/05-28-cdk-threadcreationinfo-nullable May 28, 2024 21:18
This was referenced May 28, 2024
Merged
Merged
gisripa
gisripa approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@gisripa gisripa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. From the looks of it, existing connectors are safe to ignore gen_id/sync_id (if meta not present) right ?

@edgao edgao force-pushed the edgao/generation_id_in_cdk branch from 942ef3a to e8fea2e Compare May 28, 2024 22:31
@octavia-squidington-iv octavia-squidington-iv requested a review from a team May 28, 2024 22:32
@edgao
Copy link
Contributor Author

edgao commented May 28, 2024

should be safe, yeah. I think just the compile failures from adding new params on various methods.

Base automatically changed from gireesh/05-28-cdk-threadcreationinfo-nullable to master May 28, 2024 23:05
@edgao edgao force-pushed the edgao/generation_id_in_cdk branch 2 times, most recently from 33d22aa to 8d2d17b Compare May 29, 2024 15:18
@octavia-squidington-iii octavia-squidington-iii removed the area/connectors Connector related issues label May 29, 2024
@edgao edgao force-pushed the edgao/generation_id_in_cdk branch from 8d2d17b to 2936b14 Compare May 29, 2024 18:03
@edgao
Copy link
Contributor Author

edgao commented May 29, 2024 •
edited by github-actions bot
Loading

/publish-java-cdk

🕑 https://github.com/airbytehq/airbyte/actions/runs/9290950032
✅ Successfully published Java CDK version=0.36.0!

@edgao edgao enabled auto-merge (squash) May 29, 2024 18:13
@edgao edgao merged commit f368646 into master May 29, 2024
25 checks passed
@edgao edgao deleted the edgao/generation_id_in_cdk branch May 29, 2024 18:26
xiaohansong pushed a commit that referenced this pull request May 29, 2024
@edgao @xiaohansong
Destinations CDK: generation_id/sync_id plumbing (#38358)
89a1e83
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephane-airbyte stephane-airbyte stephane-airbyte left review comments

@gisripa gisripa gisripa approved these changes

Assignees
No one assigned
Labels
CDK Connector Development Kit connectors/destination/bigquery
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@edgao @gisripa @stephane-airbyte @octavia-squidington-iii