Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destination Redshift: Adapting to Kotlin CDK #36589

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Destination Redshift: Adapting to Kotlin CDK #36589

merged 1 commit into from
Apr 2, 2024

Conversation

gisripa
Copy link
Contributor

@gisripa gisripa commented Mar 28, 2024 •
edited
Loading

TL;DR

Use kotlin converted CDK in destination-redshift

@vercel Vercel
Copy link

vercel bot commented Mar 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2024 11:40pm

@gisripa Graphite App
Copy link
Contributor Author

gisripa commented Mar 28, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @gisripa and the rest of your teammates on Graphite Graphite

@gisripa gisripa mentioned this pull request Mar 28, 2024
Merged
@gisripa gisripa marked this pull request as ready for review March 28, 2024 01:31
@gisripa gisripa requested a review from a team as a March 28, 2024 01:31
@gisripa gisripa force-pushed the gireesh/cdkk-destination-fixes branch from 3c26ac1 to 2f6585a Compare March 28, 2024 01:41
@gisripa gisripa requested a review from a team as a March 28, 2024 01:41
@gisripa gisripa force-pushed the gireesh/redshift-cdkk-fixes branch from f170a99 to 3e92440 Compare March 28, 2024 01:42
@gisripa gisripa force-pushed the gireesh/cdkk-destination-fixes branch from 2f6585a to c44486f Compare March 28, 2024 01:45
@gisripa gisripa force-pushed the gireesh/redshift-cdkk-fixes branch from 3e92440 to 166c5ce Compare March 28, 2024 01:45
@gisripa gisripa force-pushed the gireesh/cdkk-destination-fixes branch from c44486f to 5610dfe Compare March 28, 2024 01:55
@gisripa gisripa force-pushed the gireesh/redshift-cdkk-fixes branch from 166c5ce to a512eeb Compare March 28, 2024 01:55
@gisripa gisripa force-pushed the gireesh/cdkk-destination-fixes branch from 5610dfe to 183757d Compare March 28, 2024 02:01
@gisripa gisripa force-pushed the gireesh/redshift-cdkk-fixes branch from a512eeb to b15c970 Compare March 28, 2024 02:02
@gisripa gisripa force-pushed the gireesh/cdkk-destination-fixes branch from 183757d to d396108 Compare March 28, 2024 03:04
@gisripa gisripa force-pushed the gireesh/redshift-cdkk-fixes branch 2 times, most recently from addf486 to 6af8879 Compare March 28, 2024 03:06
@gisripa gisripa force-pushed the gireesh/cdkk-destination-fixes branch from d396108 to d0a2dab Compare March 28, 2024 03:31
@gisripa gisripa force-pushed the gireesh/redshift-cdkk-fixes branch from 6af8879 to f655c96 Compare March 28, 2024 03:33
@gisripa gisripa force-pushed the gireesh/cdkk-destination-fixes branch from d0a2dab to 45628cf Compare March 28, 2024 03:36
@gisripa gisripa force-pushed the gireesh/redshift-cdkk-fixes branch from f655c96 to 61749c1 Compare March 28, 2024 03:36
@gisripa gisripa force-pushed the gireesh/cdkk-destination-fixes branch from 45628cf to 73e12a1 Compare March 28, 2024 16:19
@gisripa gisripa force-pushed the gireesh/redshift-cdkk-fixes branch from 61749c1 to eac3359 Compare March 28, 2024 16:19
@gisripa gisripa force-pushed the gireesh/cdkk-destination-fixes branch from 73e12a1 to 224bcb8 Compare March 28, 2024 16:54
@gisripa gisripa force-pushed the gireesh/redshift-cdkk-fixes branch from eac3359 to d5c1b27 Compare March 28, 2024 16:54
@octavia-squidington-iv octavia-squidington-iv requested review from a team March 28, 2024 16:55
@gisripa gisripa force-pushed the gireesh/cdkk-destination-fixes branch from 224bcb8 to 7466653 Compare March 28, 2024 17:45
@gisripa gisripa force-pushed the gireesh/redshift-cdkk-fixes branch from 9cb56bc to 11be859 Compare March 28, 2024 18:25
This was referenced Mar 28, 2024
Merged
Merged
@gisripa gisripa force-pushed the gireesh/cdkk-destination-fixes branch from 08d1dcd to 9370fc8 Compare March 28, 2024 20:57
@gisripa gisripa force-pushed the gireesh/redshift-cdkk-fixes branch from 11be859 to 0cae061 Compare March 28, 2024 20:59
stephane-airbyte
stephane-airbyte suggested changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@stephane-airbyte stephane-airbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't reference the companion object. Instead, mark the CDK functions @JvmStatic

@gisripa gisripa force-pushed the gireesh/cdkk-destination-fixes branch from 9370fc8 to cd4a7c2 Compare March 28, 2024 22:41
@gisripa gisripa force-pushed the gireesh/redshift-cdkk-fixes branch from 0cae061 to 8780e0a Compare March 28, 2024 22:41
@gisripa gisripa force-pushed the gireesh/cdkk-destination-fixes branch from cd4a7c2 to f302124 Compare March 28, 2024 23:46
@gisripa gisripa force-pushed the gireesh/redshift-cdkk-fixes branch 2 times, most recently from a53a677 to 24a2264 Compare March 28, 2024 23:59
Base automatically changed from gireesh/cdkk-destination-fixes to master March 29, 2024 17:08
@gisripa gisripa force-pushed the gireesh/redshift-cdkk-fixes branch 4 times, most recently from 5162f32 to 7aaead0 Compare April 1, 2024 16:57
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Apr 1, 2024
@gisripa gisripa force-pushed the gireesh/redshift-cdkk-fixes branch from 7aaead0 to 37a7ba0 Compare April 1, 2024 16:58
@gisripa gisripa force-pushed the gireesh/redshift-cdkk-fixes branch from 37a7ba0 to 0f78d7a Compare April 1, 2024 18:26
@gisripa gisripa force-pushed the gireesh/redshift-cdkk-fixes branch from 0f78d7a to e8ee33d Compare April 1, 2024 23:35
@gisripa gisripa merged commit ca96b04 into master Apr 2, 2024
29 checks passed
@gisripa gisripa deleted the gireesh/redshift-cdkk-fixes branch April 2, 2024 00:03
@gisripa
Copy link
Contributor Author

gisripa commented Apr 2, 2024

Runs with pre-release images:
https://cloud.airbyte.com/workspaces/2c817306-57f8-4b59-bf34-d8784680946c/connections/1171c486-e2a6-4a9e-ac91-5972ab4e081d/job-history#9983389::0
https://cloud.airbyte.com/workspaces/2c817306-57f8-4b59-bf34-d8784680946c/connections/3c87bf01-ae2f-4ab0-a194-1a238003437c/job-history#9983506::0

Verified record counts

nurikk pushed a commit to nurikk/airbyte that referenced this pull request Apr 4, 2024
@gisripa @nurikk-sa
Destination Redshift: Adapting to Kotlin CDK (airbytehq#36589)
a12ee00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdpgrailsdev jdpgrailsdev jdpgrailsdev left review comments

@stephane-airbyte stephane-airbyte stephane-airbyte approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/redshift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gisripa @jdpgrailsdev @stephane-airbyte @octavia-squidington-iii