airbyte-ci: set user to airbyte on connector build #36545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
1e27a25 to
95e918c
Compare
6ad134c to
4919dad
Compare
4919dad to
5600ff1
Compare
7cecf9b to
cd91318
Compare
evantahler
approved these changes
Mar 27, 2024
Comment on lines
180
to
188
| connector_container = ( | ||
| connector_container.with_exec(["chown", "-R", user, "/airbyte"], skip_entrypoint=True) | ||
| .with_exec(["chmod", "777", "/tmp"], skip_entrypoint=True) | ||
| .with_user(user) | ||
| ) |
There was a problem hiding this comment.
I'm not entirely sure why this is needed (shouldn't every user have r/w access to /tmp?), but it is.
There was a problem hiding this comment.
I thought too, but I faced permission denied errors while writing to /tmp during the integration test run on S3
95e918c to
13f5b18
Compare
b4b3a6e to
664d070
Compare
13f5b18 to
1eef8aa
Compare
664d070 to
2f22c17
Compare
2 tasks
2f22c17 to
c58de87
Compare
1eef8aa to
c16bb07
Compare
c58de87 to
4098ec8
Compare
natikgadzhi
approved these changes
Jun 10, 2024
There was a problem hiding this comment.
I am assuming that @bgroff is correct that platform will be able to run rootless images and there are no backward compatibility concerns.
c16bb07 to
c402324
Compare
4098ec8 to
d38831b
Compare
c402324 to
c12d318
Compare
d38831b to
074b7ea
Compare
c12d318 to
c1d53e3
Compare
074b7ea to
66652de
Compare
c1d53e3 to
f7a67a8
Compare
66652de to
7767ae8
Compare
4b07f83 to
55fdc63
Compare
a2280fd to
b924361
Compare
881ef6c to
a49ee0b
Compare
b924361 to
94a4b4f
Compare
a49ee0b to
5750e7c
Compare
94a4b4f to
17ef12f
Compare
5750e7c to
dfa8a79
Compare
dfa8a79 to
de8d7ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PRs changes the connector build logic to set the user to
airbyte.