Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Source Zendesk Chat: migrate to YamlDeclarativeSource (Low-code) #35867

Merged
merged 41 commits into from
Mar 28, 2024

Conversation

bazarnov
Copy link
Collaborator

@bazarnov bazarnov commented Mar 6, 2024

What

Resolving: https://github.com/airbytehq/airbyte-internal-issues/issues/6468

How

  • by using the airbyte-cdk.declarative (Low-code)
  • added missing pk for agents_timeline stream: id to the schema
  • added 5 custom components to cover the migration:
    • bans_record_extractor - custom record_extractor for bans stream
    • id_incremental_cursor - custom cursor to provide the ability to pull data using id(int) as cursor.
    • id_offset_pagination_strategy - the pagination strategy that uses the id offset from the records and uses it as next_page_token
    • time_offset_pagination_strategy - the pagination strategy that uses timestamp from response as the next_page_token
    • timestamp_based_cursor - provides the ability to track the cursor_field values from the record instead of stream_slices and making adjustments to the request_params needed for agent_timeline and chats streams
  • covered all custom components with unit_tests
  • removed leftovers from the previous code-base
  • added migrations.md to pass QA checks as of breaking change
  • updated expected records to match the changes

🚨 User Impact 🚨

The breaking changes are avoided, with additional RECORD Transformations.

@bazarnov bazarnov self-assigned this Mar 6, 2024
Copy link

vercel bot commented Mar 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2024 8:19pm

@bazarnov bazarnov added team/connectors-python low-code-migration This connector has been migrated to the low-code CDK and removed connectors/source/zendesk-chat labels Mar 6, 2024
@bazarnov bazarnov added the breaking-change Don't merge me unless you are ready. label Mar 6, 2024
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Mar 6, 2024
@bazarnov bazarnov marked this pull request as ready for review March 6, 2024 22:56
@lazebnyi lazebnyi changed the title 🎉 Source Zendesk Chat: migrate to YamlDeclarativeSource (Low-code) 🚨🚨 Source Zendesk Chat: migrate to YamlDeclarativeSource (Low-code) Mar 11, 2024
Copy link
Contributor

@maxi297 maxi297 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bazarnov ! Can you acknowledge that the change in behaviors that were identified are fine?

@bazarnov bazarnov requested a review from maxi297 March 13, 2024 11:51
Copy link
Contributor

@maxi297 maxi297 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditional approval given:

  • Comment about id changing is resolved
  • Comment about filtering/ordering is resolve
  • Migration is properly documented

Thanks a lot @bazarnov !

@bazarnov bazarnov removed the breaking-change Don't merge me unless you are ready. label Mar 21, 2024
Copy link
Contributor

@maxi297 maxi297 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discrepancies I still see:

  • [fine with this] accounts, goals, roles, shortcuts, skills and triggers: limit has been removed
  • [fine with this] agent_timeline and chats: start_time query param is not the same but we've identify it only affects execution outside of docker
  • [fine with this] bans: caused by a bug in the previous implementation

Hence, I confirm that this change is all good. Thanks @bazarnov !

@bazarnov bazarnov changed the title 🚨🚨 Source Zendesk Chat: migrate to YamlDeclarativeSource (Low-code) Source Zendesk Chat: migrate to YamlDeclarativeSource (Low-code) Mar 23, 2024
@bazarnov bazarnov changed the title Source Zendesk Chat: migrate to YamlDeclarativeSource (Low-code) 🎉 Source Zendesk Chat: migrate to YamlDeclarativeSource (Low-code) Mar 23, 2024
@lazebnyi lazebnyi merged commit 2b2f7ef into master Mar 28, 2024
35 checks passed
@lazebnyi lazebnyi deleted the baz/source/zendesk-chat/migrate-to-low-code branch March 28, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/zendesk-chat low-code-migration This connector has been migrated to the low-code CDK team/connectors-python
Projects
No open projects
Status: Implementation in progress
Development

Successfully merging this pull request may close these issues.

4 participants