-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 Source Zendesk Chat: migrate to YamlDeclarativeSource (Low-code)
#35867
🎉 Source Zendesk Chat: migrate to YamlDeclarativeSource (Low-code)
#35867
Conversation
…chat/migrate-to-low-code
…chat/migrate-to-low-code
…chat/migrate-to-low-code
…chat/migrate-to-low-code
…chat/migrate-to-low-code
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…chat/migrate-to-low-code
YamlDeclarativeSource (Low-code)
YamlDeclarativeSource (Low-code)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bazarnov ! Can you acknowledge that the change in behaviors that were identified are fine?
airbyte-integrations/connectors/source-zendesk-chat/source_zendesk_chat/manifest.yaml
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-zendesk-chat/source_zendesk_chat/manifest.yaml
Show resolved
Hide resolved
airbyte-integrations/connectors/source-zendesk-chat/source_zendesk_chat/manifest.yaml
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-zendesk-chat/source_zendesk_chat/manifest.yaml
Show resolved
Hide resolved
...tions/connectors/source-zendesk-chat/source_zendesk_chat/components/bans_record_extractor.py
Show resolved
Hide resolved
...tions/connectors/source-zendesk-chat/source_zendesk_chat/components/id_incremental_cursor.py
Show resolved
Hide resolved
...tions/connectors/source-zendesk-chat/source_zendesk_chat/components/bans_record_extractor.py
Show resolved
Hide resolved
airbyte-integrations/connectors/source-zendesk-chat/source_zendesk_chat/manifest.yaml
Show resolved
Hide resolved
...tions/connectors/source-zendesk-chat/source_zendesk_chat/components/id_incremental_cursor.py
Show resolved
Hide resolved
…chat/migrate-to-low-code
…chat/migrate-to-low-code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conditional approval given:
- Comment about id changing is resolved
- Comment about filtering/ordering is resolve
- Migration is properly documented
Thanks a lot @bazarnov !
…chat/migrate-to-low-code
…chat/migrate-to-low-code
…chat/migrate-to-low-code
…chat/migrate-to-low-code
…chat/migrate-to-low-code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discrepancies I still see:
- [fine with this] accounts, goals, roles, shortcuts, skills and triggers: limit has been removed
- [fine with this] agent_timeline and chats:
start_time
query param is not the same but we've identify it only affects execution outside of docker - [fine with this] bans: caused by a bug in the previous implementation
Hence, I confirm that this change is all good. Thanks @bazarnov !
YamlDeclarativeSource (Low-code)
YamlDeclarativeSource (Low-code)
YamlDeclarativeSource (Low-code)
YamlDeclarativeSource (Low-code)
What
Resolving: https://github.com/airbytehq/airbyte-internal-issues/issues/6468
How
pk
foragents_timeline
stream:id
to the schemabans_record_extractor
- customrecord_extractor
forbans
streamid_incremental_cursor
- customcursor
to provide the ability to pull data usingid
(int) as cursor.id_offset_pagination_strategy
- the pagination strategy that uses theid
offset from therecords
and uses it asnext_page_token
time_offset_pagination_strategy
- the pagination strategy that usestimestamp
fromresponse
as thenext_page_token
timestamp_based_cursor
- provides the ability to track thecursor_field
values from therecord
instead ofstream_slices
and making adjustments to therequest_params
needed foragent_timeline
andchats
streamsunit_tests
leftovers
from the previous code-basemigrations.md
to passQA
checks as ofbreaking change
expected records
to match the changes🚨 User Impact 🚨
The breaking changes are avoided, with additional RECORD Transformations.