Pass docker hub credentials to airbyte-ci's bump_version command
#35802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
alafanechere
approved these changes
Mar 5, 2024
There was a problem hiding this comment.
Thanks for the fix!
These credentials are required because MetadataValidation happens during the execution flow (to validate that the new metadata file is correct).
MetadataValidation checks that the base image declared in it exists on dockerhub, and to do so it has to call dockerhub api.
If not logged in, DockerHub API returns a 403 and not a 404 when the image is not found... Hence the requirement for credentials.
We could decide to remove this validation in metadata ...
alafanechere
approved these changes
Mar 5, 2024
9ac4997 to
74a2c7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The
bump_versioncommand, as part of its process to bump the connector version tag in itsmetadata.yamlfile, validates the metadata. The pipeline step that does this requires the docker hub credentials to be passed in (should it? That's a separate question). Thebump_versioncommand does not pass them in when creating the context for the pipeline's execution. This PR changes that.Airbyters can read this slack thread for additional context.
🚨 User Impact 🚨
People bumping versions with
airbyte-ci connectors --name $connector_name bump_version $argswill actually succeed as long as they don't mess up their CLI args.