change aritfact link file name #35504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
This was referenced Feb 21, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @stephane-airbyte and the rest of your teammates on |
This was referenced Feb 21, 2024
5a1fa07 to
be0b10a
Compare
This was referenced Feb 21, 2024
Closed
e8d0597 to
64b93e4
Compare
4d46fa1 to
d5b2638
Compare
51a3f8b to
5505b42
Compare
64b93e4 to
a83baa1
Compare
5505b42 to
10a4d5a
Compare
a83baa1 to
3c6b12d
Compare
82b4f40 to
2b4f711
Compare
3c6b12d to
2a47e7d
Compare
db04e03 to
ae62e61
Compare
ae62e61 to
f85606d
Compare
| @@ -171,7 +171,7 @@ function copyToClipBoard(htmlElement) { | |||
| <h3>Artifacts</h3> | |||
| <ul> | |||
| {% for artifact in step_result_to_artifact_links[step_result.step.title] %} | |||
| <li><a href="{{ artifact.url }}">{{ artifact.name }}</a></li> | |||
| <li><a href="{{ artifact.url }}" download>{{ artifact.name }}</a></li> | |||
There was a problem hiding this comment.
Suggested change
| <li><a href="{{ artifact.url }}" download>{{ artifact.name }}</a></li> | |
| <li><a href="{{ artifact.url }}">Download {{ artifact.name }}</a></li> |
| if test_results_dir_name not in await gradle_container.directory(f"{self.context.connector.code_directory}/build").entries(): | ||
| self.context.logger.warn(f"No {test_results_dir_name} found directory in the build folder") | ||
| test_results_dir_name_in_container = "test-results" | ||
| test_results_dir_name_in_zip = f"test-results-{datetime.fromtimestamp(cast(float, self.context.pipeline_start_timestamp)).isoformat()}-{self.context.git_branch}-{self.gradle_task_name}".replace( |
There was a problem hiding this comment.
nit: this can be declared after the next ifstatement as its only used if the test_results_dir_name_in_containerexists.
| @@ -29,7 +29,9 @@ async def save_to_local_path(self, path: Path) -> Path: | |||
| raise Exception(f"Failed to save artifact {self.name} to local path {path}") | |||
|
|
|||
| async def upload_to_gcs(self, dagger_client: dagger.Client, bucket: str, key: str, gcs_credentials: dagger.Secret) -> str: | |||
| gcs_cp_flags = None if self.content_type is None else [f"--content-type={self.content_type}"] | |||
| gcs_cp_flags = [f"--content-disposition=filename=\"{self.name}\""] | |||
There was a problem hiding this comment.
Can you share why this addition is required?
Base automatically changed from
augustin/02-21-airbyte-ci_rename_StepResult.output_artifact_to_StepResult.output
to
stephane/02-13-make_airbyte-ci_pass_a_parameter_to_the_java_connectors_to_the_location_of_the_logs
February 22, 2024 15:16
f85606d
into
stephane/02-13-make_airbyte-ci_pass_a_parameter_to_the_java_connectors_to_the_location_of_the_logs
24 of 25 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.