-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 Source Slack migration to low code #35477
Merged
Merged
Changes from 93 commits
Commits
Show all changes
95 commits
Select commit
Hold shift + click to select a range
bd8a4c8
Revert "updated Prerequisites"
midavadim 56daf02
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim 8ad4061
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim 2cab1ff
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim 6aae53d
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim e45624c
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim c923aa9
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim be763e2
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim 4883642
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim 3e2c793
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim d948037
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim 4736e76
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim b4ef214
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim c0376ab
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim ed7dbd7
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim 703880f
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim a22e333
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim cb00fc2
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim 854f87d
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim c68a752
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim d13e69f
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim 9795a7d
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim 8358894
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim 0b8ee3b
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim 7d55bad
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim 9fa8a29
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim 7cab07a
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim 85e72ed
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim bdde638
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim 0031711
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim cd2c611
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim 8d23ce2
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim 162b096
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim d94c4dd
Merge branch 'master' of https://github.com/airbytehq/airbyte
midavadim d2083b9
low code migration
midavadim 602b92f
added join_channels and channel_filter options
midavadim e84a1c2
added threads
midavadim 53718a1
inclusive params and lookback_window
midavadim e7a034f
use_lookback_window handle
midavadim 3788cc2
refactoring
midavadim 44ef205
refactoring
midavadim 21a2e82
added channel_id to threads
midavadim 175970d
added oauth2 support, fixed expected records, added error handler
midavadim c45a766
cleanup
midavadim 7348e7f
updated auth in manifest, removed custom component
darynaishchenko 563daa1
added selective auth, updated streams impelemntation
darynaishchenko 7192ba2
updated expected records
darynaishchenko af74589
updated components
darynaishchenko 3d48905
added migration for legacy config
darynaishchenko 320a675
updated unittests
darynaishchenko 53e93d2
added dependencies
darynaishchenko f622dcb
delete unused fiels, added .coveragerc
darynaishchenko e874d06
updated source.py and run.py
darynaishchenko 5c36ec9
updated abnormal_state
darynaishchenko a5b26ca
added request param for channels stream
darynaishchenko 42a499f
updated dependencies
darynaishchenko b567508
bump version, added migration docs
darynaishchenko af8d4e4
format fix
darynaishchenko 3ad394f
Merge branch 'master' into midavadim/source-slack-to-low-code
darynaishchenko 3d571a3
updated to latesl cdk
darynaishchenko 5cebd2d
updated stream slices in custom partition router
darynaishchenko a898a70
added header for migration guide
darynaishchenko 0c24c5f
updated tags
darynaishchenko dfd3eac
moved join channels logic to custom retriever for channels stream
darynaishchenko d0f1b69
Merge branch 'master' into midavadim/source-slack-to-low-code
darynaishchenko 42f8309
refactor code
darynaishchenko bf4cb5d
fix channel messages transformation
darynaishchenko b95bbd8
updated expected records
darynaishchenko 47e850c
Merge branch 'master' into midavadim/source-slack-to-low-code
darynaishchenko 2c94e4e
updated cases for check test
darynaishchenko b89e7f4
updated channel messages and threads streams with correct float_ts value
darynaishchenko 53c3207
added validation for request params in threads stream
darynaishchenko 935e818
updated tests
darynaishchenko 29979bf
Merge branch 'master' into midavadim/source-slack-to-low-code
alafanechere a1ae4f4
fix channels filter
darynaishchenko 87b1544
poetry update
darynaishchenko 92c5f05
fix requests in threads stream
darynaishchenko 82e288f
format fix
darynaishchenko a36d6cd
reverted threads stream to python implementation
darynaishchenko 2537e03
updated unit test
darynaishchenko 6ce6404
Merge branch 'master' into midavadim/source-slack-to-low-code
darynaishchenko f23f55e
update poetry.lock
darynaishchenko 37de0b8
refactor code+updated expected records
darynaishchenko 0e92f78
Merge branch 'master' into midavadim/source-slack-to-low-code
alafanechere 8f967ac
format fix
darynaishchenko 9b48589
updated migration guide
darynaishchenko f1a317b
add lookback for channel_messages_stream and 503 handling
darynaishchenko 6fadec0
add 500 handling
darynaishchenko f67b342
updated threads stream parent streams
darynaishchenko 47c6400
updated unit tests
darynaishchenko 3163df5
updated breakingChanges message
darynaishchenko e3ee23b
updated upgradeDeadline
darynaishchenko ca452f4
updated docs
darynaishchenko af613b2
updated changelog
darynaishchenko deb7918
updated poetry.lock
darynaishchenko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
[run] | ||
omit = | ||
source_slack/run.py |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 11 additions & 9 deletions
20
airbyte-integrations/connectors/source-slack/integration_tests/expected_records.jsonl
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
108 changes: 61 additions & 47 deletions
108
airbyte-integrations/connectors/source-slack/poetry.lock
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
21 changes: 21 additions & 0 deletions
21
...integrations/connectors/source-slack/source_slack/components/channel_members_extractor.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,21 @@ | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
# Copyright (c) 2023 Airbyte, Inc., all rights reserved. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
from dataclasses import dataclass | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
from typing import List | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
import requests | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
from airbyte_cdk.sources.declarative.extractors import DpathExtractor | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
from airbyte_cdk.sources.declarative.types import Record | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
@dataclass | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
class ChannelMembersExtractor(DpathExtractor): | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
""" | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Transform response from list of strings to list dicts: | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
from: ['aa', 'bb'] | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
to: [{'member_id': 'aa'}, {{'member_id': 'bb'}] | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
""" | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
def extract_records(self, response: requests.Response) -> List[Record]: | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
records = super().extract_records(response) | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
return [{"member_id": record} for record in records] |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should properly handle errors from slack. like it was before:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please give me an example that is not covered in this handling errors implementation? Now it works the same as in #35477 (comment), but instead of AirbyteTracedException it raises airbyte_cdk.sources.declarative.exceptions.ReadException.