Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

airbyte-lib: Refactor follow-up #34649

Merged
merged 3 commits into from
Jan 30, 2024
Merged

airbyte-lib: Refactor follow-up #34649

merged 3 commits into from
Jan 30, 2024

Conversation

flash1293
Copy link
Contributor

@flash1293 flash1293 commented Jan 30, 2024 •
edited
Loading

This is a follow-up to #34552

The package_data needs to be set correctly for airbyte-lib connectors as otherwise some json/yaml files are missing. This doesn't affect the docker image build as it will bundle all files regardless whether they show up in package_data or not.

This was already fixed for most connectors in the original PR, but I missed some connectors. This PR follows up on this and fixes the rest of the connectors - now all python sources specify the same package data.

The generator template for new connectors will be adjusted in a follow-up PR.

@vercel Vercel
Copy link

vercel bot commented Jan 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jan 30, 2024 10:40am

@octavia-squidington-iv octavia-squidington-iv requested a review from a team January 30, 2024 10:18
@flash1293 flash1293 marked this pull request as draft January 30, 2024 10:23
@flash1293 flash1293 marked this pull request as ready for review January 30, 2024 10:40
@flash1293
Copy link
Contributor Author

@alafanechere A follow-up to the refactoring PR; I missed some bits

@alafanechere
Copy link
Contributor

alafanechere commented Jan 30, 2024 •
edited by github-actions bot
Loading

/approve-and-merge reason="we decided that this kind of global changes can bypass CI"

Important: This command can only be run by one of the repository admins:
bleonard, natikgadzhi, perangel, bgroff, evantahler, wennergr, timroes, malikdiarra, bnchrch, git-phu, girarda, postamar, midavadim,

1 similar comment
@alafanechere
Copy link
Contributor

alafanechere commented Jan 30, 2024 •
edited by github-actions bot
Loading

/approve-and-merge reason="we decided that this kind of global changes can bypass CI"

Important: This command can only be run by one of the repository admins:
bleonard, natikgadzhi, perangel, bgroff, evantahler, wennergr, timroes, malikdiarra, bnchrch, git-phu, girarda, postamar, midavadim,

@alafanechere alafanechere merged commit 4cfaebe into master Jan 30, 2024
21 of 119 checks passed
@alafanechere alafanechere deleted the flash1293/refactor-followup branch January 30, 2024 11:11
jbfbell pushed a commit that referenced this pull request Feb 1, 2024
@jbfbell
airbyte-lib: Refactor follow-up (#34649)
cc1f1a2
@jbfbell jbfbell mentioned this pull request Feb 21, 2024
Closed
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 21, 2024
@jatinyadav-cc
airbyte-lib: Refactor follow-up (airbytehq#34649)
9ec4a8d
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@jatinyadav-cc
airbyte-lib: Refactor follow-up (airbytehq#34649)
e3d7128
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@jatinyadav-cc
airbyte-lib: Refactor follow-up (airbytehq#34649)
1e8cf53
@jbfbell jbfbell mentioned this pull request Mar 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/connectors Connector related issues connectors/source/airtable connectors/source/amazon-ads connectors/source/amazon-seller-partner connectors/source/amazon-sqs connectors/source/appsflyer connectors/source/appstore-singer connectors/source/asana connectors/source/aws-cloudtrail connectors/source/azure-blob-storage connectors/source/azure-table connectors/source/bamboo-hr connectors/source/bing-ads connectors/source/cart connectors/source/chartmogul connectors/source/close-com connectors/source/delighted connectors/source/dv-360 connectors/source/facebook-marketing connectors/source/faker connectors/source/fauna connectors/source/file connectors/source/firebase-realtime-database connectors/source/firebolt connectors/source/freshdesk connectors/source/gcs connectors/source/github connectors/source/gitlab connectors/source/google-ads connectors/source/google-analytics-data-api connectors/source/google-analytics-v4 connectors/source/google-directory connectors/source/google-drive connectors/source/google-search-console connectors/source/google-workspace-admin-reports connectors/source/greenhouse connectors/source/harvest connectors/source/hubspot connectors/source/instagram connectors/source/iterable connectors/source/jira connectors/source/klaviyo connectors/source/kustomer-singer connectors/source/kyriba connectors/source/kyve connectors/source/lever-hiring connectors/source/linkedin-ads connectors/source/linkedin-pages connectors/source/linnworks connectors/source/looker connectors/source/mailchimp connectors/source/marketo connectors/source/microsoft-teams connectors/source/mixpanel connectors/source/monday connectors/source/my-hours connectors/source/notion connectors/source/okta connectors/source/orb connectors/source/outreach connectors/source/pardot connectors/source/paystack connectors/source/pinterest connectors/source/pivotal-tracker connectors/source/posthog connectors/source/python-http-tutorial connectors/source/recharge connectors/source/recurly connectors/source/rki-covid connectors/source/s3 connectors/source/salesloft connectors/source/scaffold-source-python connectors/source/search-metrics connectors/source/sendgrid connectors/source/sentry connectors/source/sftp-bulk connectors/source/shopify connectors/source/slack connectors/source/smartsheets connectors/source/snapchat-marketing connectors/source/surveymonkey connectors/source/talkdesk-explore connectors/source/tempo connectors/source/tiktok-marketing connectors/source/tplcentral connectors/source/twilio connectors/source/us-census connectors/source/youtube-analytics connectors/source/zendesk-chat connectors/source/zendesk-support connectors/source/zendesk-talk connectors/source/zenloop connectors/source/zoho-crm connectors/source/zuora
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flash1293 @alafanechere @octavia-squidington-iii