-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
airbyte-ci: Introduce --only-step
option for connector tests
#34276
airbyte-ci: Introduce --only-step
option for connector tests
#34276
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @alafanechere and the rest of your teammates on |
Apply Sweep Rules to your PR?
This is an automated message generated by Sweep AI. |
6d77c61
to
e7cd07b
Compare
![]() Fixing PR: track the progress here.I'm currently fixing this PR to address the following: [Sweep GHA Fix] The GitHub Actions run failed with the following error logs:
An error has occurred: Cmd('git') failed due to: exit code(128) |
![]() Fixing PR: track the progress here.I'm currently fixing this PR to address the following: [Sweep GHA Fix] The GitHub Actions run failed with the following error logs:
An error has occurred: Cmd('git') failed due to: exit code(128) |
e7cd07b
to
75541e9
Compare
![]() Fixing PR: track the progress here.I'm currently fixing this PR to address the following: [Sweep GHA Fix] The GitHub Actions run failed with the following error logs:
An error has occurred: Cmd('git') failed due to: exit code(128) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
log_step_tree: bool = True | ||
concurrency: int = 10 | ||
step_params: Dict[CONNECTOR_TEST_STEP_ID, STEP_PARAMS] = field(default_factory=dict) | ||
|
||
def __post_init__(self) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍
@@ -232,7 +295,7 @@ async def run_steps( | |||
steps_to_evaluate, remaining_steps = _get_next_step_group(runnables) | |||
|
|||
# Remove any skipped steps | |||
steps_to_run, results = _filter_skipped_steps(steps_to_evaluate, options.skip_steps, results) | |||
steps_to_run, results = _filter_skipped_steps(steps_to_evaluate, step_ids_to_skip, results) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍
if self.skip_steps and self.keep_steps: | ||
raise ValueError("Cannot use both skip_steps and keep_steps at the same time") | ||
|
||
def get_step_ids_to_skip(self, runnables: STEP_TREE) -> List[str]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❗This is all great. Only thing thats missing is some tests to ensure weve got the traversal correct
a4ec1e5
to
21af651
Compare
What
This introduces an option on
connectors test
to only run a specific test suite.E.G: Only running acceptance tests
airbyte-ci connectors --name=source-faker test --only-step=acceptance
How
--only-step/-k
option to `test``run_steps
to only run theonly-step
and its dependencies - and skip the others.