Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

airbyte-ci: fix types (mypy) #33785

Merged
merged 4 commits into from
Jan 4, 2024
Merged

airbyte-ci: fix types (mypy) #33785

merged 4 commits into from
Jan 4, 2024

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Dec 26, 2023 •
edited
Loading

What

Relates to #33719
Run mypy pipelines --check-untyped-defs on the pipelines package and fix all the errors.
Mypy is installed and enabled in the CI in #33712.

🚨 User Impact 🚨

None

Pre-merge Actions

@vercel Vercel
Copy link

vercel bot commented Dec 26, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jan 4, 2024 9:59am

@github-actions GitHub Actions
Copy link
Contributor

Warning

Soft code freeze is in effect until 2024-01-02. Please avoid merging to master. #freedom-and-responsibility

This was referenced Dec 26, 2023
Merged
Merged
@alafanechere Graphite App
Copy link
Contributor Author

alafanechere commented Dec 26, 2023 •
edited
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@alafanechere alafanechere force-pushed the augustin/12-26-airbyte-ci_fix_types_mypy_ branch 2 times, most recently from a9cce7f to accff15 Compare December 26, 2023 18:45
@alafanechere alafanechere changed the base branch from augustin/12-21-airbyte-ci_enable_mypy to augustin/12-26-airbyte-ci_make_airbyte-ci_test_able_to_run_any_poetry_run_command December 26, 2023 18:45
@alafanechere alafanechere force-pushed the augustin/12-26-airbyte-ci_make_airbyte-ci_test_able_to_run_any_poetry_run_command branch from 9a6d133 to ab794c1 Compare December 26, 2023 19:16
@alafanechere alafanechere force-pushed the augustin/12-26-airbyte-ci_fix_types_mypy_ branch from accff15 to c2845e6 Compare December 26, 2023 19:16
@alafanechere alafanechere marked this pull request as ready for review December 27, 2023 07:52
@alafanechere alafanechere requested a review from a team December 27, 2023 07:52
@alafanechere alafanechere force-pushed the augustin/12-26-airbyte-ci_fix_types_mypy_ branch from 1acf460 to 455730d Compare December 27, 2023 08:25
@alafanechere alafanechere mentioned this pull request Dec 27, 2023
Merged
@alafanechere alafanechere force-pushed the augustin/12-26-airbyte-ci_make_airbyte-ci_test_able_to_run_any_poetry_run_command branch from 3a4bd1e to 6b1ff5e Compare December 27, 2023 12:02
@alafanechere alafanechere force-pushed the augustin/12-26-airbyte-ci_fix_types_mypy_ branch 2 times, most recently from 9a7cf4c to 51f699e Compare December 27, 2023 12:22
@alafanechere alafanechere force-pushed the augustin/12-26-airbyte-ci_make_airbyte-ci_test_able_to_run_any_poetry_run_command branch from 6b1ff5e to b8a63f7 Compare January 3, 2024 13:21
@alafanechere alafanechere force-pushed the augustin/12-26-airbyte-ci_fix_types_mypy_ branch from c5896ba to 41586fb Compare January 3, 2024 13:22
@alafanechere alafanechere force-pushed the augustin/12-26-airbyte-ci_make_airbyte-ci_test_able_to_run_any_poetry_run_command branch from 9ed1ae5 to 05f5378 Compare January 3, 2024 16:24
@alafanechere alafanechere force-pushed the augustin/12-26-airbyte-ci_fix_types_mypy_ branch from 41586fb to 5c9730c Compare January 3, 2024 16:25
Base automatically changed from augustin/12-26-airbyte-ci_make_airbyte-ci_test_able_to_run_any_poetry_run_command to master January 3, 2024 16:45
postamar
postamar approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@postamar postamar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If mypy's happy then I'm happy.

@alafanechere alafanechere force-pushed the augustin/12-26-airbyte-ci_fix_types_mypy_ branch from 5c9730c to ae85640 Compare January 4, 2024 09:57
@alafanechere alafanechere enabled auto-merge (squash) January 4, 2024 09:58
@alafanechere alafanechere merged commit 917f420 into master Jan 4, 2024
21 checks passed
@alafanechere alafanechere deleted the augustin/12-26-airbyte-ci_fix_types_mypy_ branch January 4, 2024 10:10
@sentry-io Sentry.io
Copy link

sentry-io bot commented Jan 4, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ AssertionError: The report was not set on this PipelineContext. pipelines.models.contexts.pipeline_context in r... View Issue

Did you find this useful? React with a 👍 or 👎

edgao added a commit that referenced this pull request Jan 4, 2024
@edgao
Revert "airbyte-ci: fix types (mypy) (#33785)"
c0ccde6 
This reverts commit 917f420.
@alafanechere alafanechere mentioned this pull request Jan 5, 2024
Merged
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@alafanechere @jatinyadav-cc
airbyte-ci: fix types (mypy) (airbytehq#33785)
1d2ee31
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@alafanechere @jatinyadav-cc
airbyte-ci: fix types (mypy) (airbytehq#33785)
04370dc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@postamar postamar postamar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alafanechere @postamar