-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update airbyte-ci action to install dev if pipeline has been edited #33519
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fdeaa9b
to
1ba7845
Compare
branches: | ||
- master | ||
paths: | ||
- "airbyte-ci/connectors/pipelines/**" | ||
pull_request: | ||
types: | ||
- opened | ||
- reopened | ||
- synchronize | ||
paths: | ||
- "airbyte-ci/connectors/pipelines/**" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I'm not mistaken the release will be triggered on airbyte-ci
file changes only.
So if you make a change to a non airbyte-ci related file on a later commit the run-dagger-pipeline/action.yml
will never resolve a binary for this commit.
I think that a dev install with pipx when the PR (not the commit) has airbyte-ci
modified files is easier to implement.
Another option would be to always trigger this workflow (no paths
filter) and use tj-actions/changed-files
to only trigger a release if the branch has airbyte-ci modified files.
I'm not sure if tj-actions/changed-files
returns the changed-files compared to the previous commit or compared to the target branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I'm not mistaken the release will be triggered on airbyte-ci file changes only.
So interestingly enough this was the case previously when using push.paths
. However its not the case for pull_request.paths
+ pull_request.types=synchronize
, which will fire everytime the branch is update and there is a change matching the path in anyone of the commits that make up the branch
I think that a dev install with pipx when the PR (not the commit) has airbyte-ci modified files is easier to implement.
I think your right. I went down this path as it would be useful to test pipeline changes using the final pyinstaller executable. As this is what the end users actually run.
But looking at this now, the steps we take to poll for new dev binaries that match your commit is brittle and more complex than we should tolerate.
TLDR: Ill update to use the pipx dev install instead
07f2988
to
7f98892
Compare
@alafanechere back up and ready for review. We no longer are using the dev executables but instead the pipx install. Much simpler. |
This reverts commit 8baadc7.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I confirm it works: I opened a PR based on this one on which I've modified pipeline code -> the formatting workflow installs airbyte-ci with pipx
Overview
closes #33418
Pain points