Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
airbyte-ci: Add upgrade cdk command #33313
airbyte-ci: Add upgrade cdk command #33313
Changes from 15 commits
1b984f1
7b39d11
806e26f
6624da4
ee847f0
7d2f58d
5564fc8
b8aec3a
0d42b01
da6d1d2
ee7ef31
46b76eb
2a30eb0
867e427
c77890e
64324a1
84c0662
d499e9f
9528948
f75f2a1
0ad032f
006a010
6341690
cb7adf3
f3a3d89
6dba66f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
repo_dir
is already an attribute ofcontext
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we move the export logic back to the SetCDKVersion so that a failed export fails the step (and the report)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should export the connector directory and not the full repo directory. This will improve performances.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be more stable to not rely on a single connector. I suggest to iterate on the
all_connectors
fixture and return a connector which has apyproject.toml
file and skip otherwise.