✨ Source Chargebee: add new fields in streams #32098 #32100

KimPlv · 2023-11-02T15:51:45Z

Issue : #32097

What

Add new fields:

addon:

channel
object
type

coupons:

object

credit_notes

base_currency_code
business_entity_id
channel
exchange_rate
is_digital
is_vat_moss_registered
object

customers:

business_entity_id
channel
object

event:

object

invoices:

base_currency_code

channel

object

item:

external_name

orders:

base_currency_code
business_entity_id
exchange_rate
object

payment_source:

object

plan:

channel
charge_model
object

promotional_credits:

object

subscriptions:

business_entity_id
channel

transactions:

base_currency_code
business_entity_id
error_text
object
payment_method_details
reference_number

How

update schema folders

vercel · 2023-11-02T15:51:50Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
airbyte-docs	⬜️ Ignored (Inspect)	Visit Preview		Dec 19, 2023 9:48am

github-actions · 2023-11-02T15:52:08Z

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

PR name follows PR naming conventions
Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
Secrets in the connector's spec are annotated with airbyte_secret
All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

Check for hidden checklists in your PR description
Toggle the github label checklist-action-run on/off to re-run the checklist CI.

marcosmarxm

Can you bump the metadata, dockerfile and doc changelog version?

marcosmarxm · 2023-11-07T12:44:22Z

Thanks for the contribution @KimPlv is it possible to give me access to your branch? I need to send some updates for expected records.

KimPlv · 2023-11-07T16:16:55Z

Can you bump the metadata, dockerfile and doc changelog version?

Update for the DockerImageTag in metadata.yaml
Changelog version in doc already increased
No Dockerfile

KimPlv · 2023-11-07T16:18:18Z

Thanks for the contribution @KimPlv is it possible to give me access to your branch? I need to send some updates for expected records.

You should be able to access our repo, it's https://github.com/sendinblue/airbyte/tree/chargebee_add_new_field

lideke · 2023-11-17T16:41:30Z

Hi @marcosmarxm,
We are facing more issues with chargebee where some fields are missing.
Right now i'm switching to our build but it will be great if you can accept the PR.
Thanks

marcosmarxm · 2023-11-22T17:56:40Z

Hello @KimPlv sorry the delay to get this merged. This week the codebase is freeze because of holidays. I'll run tests and return to you, thanks for the patience.

lideke · 2023-11-23T08:42:55Z

Hello @KimPlv sorry the delay to get this merged. This week the codebase is freeze because of holidays. I'll run tests and return to you, thanks for the patience.

Hi @marcosmarxm, Kim she on vacation, i'll follow the PR
Just to let you know we are already using in our side on production for missing fields in chargebee streams
Thanks you to take time to test and validate the PR

pnilan · 2023-12-14T18:03:33Z

@lideke @KimPlv I can't seem to find any record of is_vat_moss_registered in the Chargebee API documentation for credits_notes. Also does not show up in the sample responses. Can you verify this field for the credits_notes stream? Thanks.

pnilan · 2023-12-14T18:04:58Z

airbyte-integrations/connectors/source-chargebee/source_chargebee/schemas/credit_note.json

+        "null"
+      ]
+    },
+    "is_vat_moss_registered": {


Please verify this field and its datatype.

Hi @pnilan, we can collect data for this field, but it depends on the record, in some cases we have it and in others not. That's why i've removed the field from the credit note schema, and added "additionalProperties" to true to include it anyway. It's good for you like this ?

@KimPlv Thanks for the confirmation. I confirmed with Chargebee support that this specific field is only available for accounts that are configured for EU taxes, which is why it wasn't populating on my end. I think we can go ahead and include it in the schema and add a $comment property to note this.

I will update this on my end and verify the tests are running properly and then we should be able to merge the PR. I will have to merge this as a separate PR though for our CI pipeline to run properly. I'll let you know when I have the PR submitted.

@pnilan fine ! Thanks for the information. I've made the change for this field

octavia-squidington-iii added area/connectors Connector related issues community connectors/source/chargebee labels Nov 2, 2023

octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Nov 2, 2023

vercel bot deployed to Preview November 2, 2023 16:04 View deployment

KimPlv marked this pull request as draft November 2, 2023 16:28

KimPlv changed the title ~~✨ Source Chargebee: add new field in Invoice stream #32098~~ ✨ Source Chargebee: add new fields in streams #32098 Nov 2, 2023

KimPlv marked this pull request as ready for review November 2, 2023 18:01

vercel bot deployed to Preview November 2, 2023 18:03 View deployment

KimPlv force-pushed the chargebee_add_new_field branch from dde5cb1 to b5bd770 Compare November 2, 2023 18:03

vercel bot deployed to Preview November 2, 2023 18:08 View deployment

marcosmarxm added the gl label Nov 7, 2023

marcosmarxm requested changes Nov 7, 2023

View reviewed changes

lideke force-pushed the chargebee_add_new_field branch 2 times, most recently from b9eeeeb to 53f07c3 Compare November 17, 2023 21:36

oustynova added team/connectors-python and removed gl labels Nov 29, 2023

katmarkham requested a review from pnilan December 12, 2023 17:24

pnilan requested changes Dec 14, 2023

View reviewed changes

KimPlv added 2 commits December 18, 2023 11:09

add new field business_entity_id

02afc94

update doc

8ca1c31

KimPlv added 4 commits December 18, 2023 11:09

update version

3d5890a

add new fields

94ed3ba

fix json

f329502

update version dockerImageTag metadata

57d9171

KimPlv force-pushed the chargebee_add_new_field branch from 53f07c3 to 57d9171 Compare December 18, 2023 10:09

KimPlv added 2 commits December 18, 2023 11:09

add additionalProperties for credit_note schema

9fb34c7

rollback is_vat_moss_registered field in credit note json

fe8c1d7

pnilan mentioned this pull request Dec 20, 2023

✨ Source Chargebee: add new fields in streams #33661

Merged

pnilan closed this in #33661 Dec 20, 2023

KimPlv deleted the chargebee_add_new_field branch January 23, 2024 17:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ Source Chargebee: add new fields in streams #32098 #32100

✨ Source Chargebee: add new fields in streams #32098 #32100

KimPlv commented Nov 2, 2023 •

edited

Loading

vercel bot commented Nov 2, 2023 •

edited

Loading

github-actions bot commented Nov 2, 2023

marcosmarxm left a comment

marcosmarxm commented Nov 7, 2023

KimPlv commented Nov 7, 2023

KimPlv commented Nov 7, 2023

lideke commented Nov 17, 2023

marcosmarxm commented Nov 22, 2023

lideke commented Nov 23, 2023

pnilan commented Dec 14, 2023

pnilan Dec 14, 2023 •

edited

Loading

KimPlv Dec 18, 2023

pnilan Dec 18, 2023

KimPlv Dec 19, 2023

✨ Source Chargebee: add new fields in streams #32098 #32100

✨ Source Chargebee: add new fields in streams #32098 #32100

Conversation

KimPlv commented Nov 2, 2023 • edited Loading

Issue : #32097

What

How

vercel bot commented Nov 2, 2023 • edited Loading

github-actions bot commented Nov 2, 2023

Before Merging a Connector Pull Request

marcosmarxm left a comment

Choose a reason for hiding this comment

marcosmarxm commented Nov 7, 2023

KimPlv commented Nov 7, 2023

KimPlv commented Nov 7, 2023

lideke commented Nov 17, 2023

marcosmarxm commented Nov 22, 2023

lideke commented Nov 23, 2023

pnilan commented Dec 14, 2023

pnilan Dec 14, 2023 • edited Loading

Choose a reason for hiding this comment

KimPlv Dec 18, 2023

Choose a reason for hiding this comment

pnilan Dec 18, 2023

Choose a reason for hiding this comment

KimPlv Dec 19, 2023

Choose a reason for hiding this comment

KimPlv commented Nov 2, 2023 •

edited

Loading

vercel bot commented Nov 2, 2023 •

edited

Loading

pnilan Dec 14, 2023 •

edited

Loading